Validate cloudpickle content hash#5103
Open
schustmi wants to merge 1 commit into
Open
Conversation
schustmi
added
enhancement
schustmi
force-pushed
the
feature/validate-cloudpick-content-hash
branch
from
July 20, 2026 15:33
f03ecbc to
1bf1316
Compare
bcdurak
approved these changes
Jul 23, 2026
bcdurak
left a comment
bcdurak
left a comment
Contributor
There was a problem hiding this comment.
Left a small nitpick comment, otherwise looks good.
|
|
||
| # Content hash recorded for the artifact version, set by the loading | ||
| # machinery before `load` so materializers can validate the stored data. | ||
| expected_content_hash: Optional[str] = None |
Contributor
There was a problem hiding this comment.
I am a bit surprised to see this as a class attribute. Wouldn't it be more consistent to treat this as an instance variable like the uri that is dependent on the artifact version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record the SHA-256 of the stored file when the cloudpickle materializer saves an artifact and validate it before loading the artifact back.