z_player Dark Link states#2768
Open
djevangelia wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three Dark Link related states (room reflection, immobilization by Deku Nut/jump on sword, falling through the floor).
I did a small recording showing the states and the described bug: https://www.youtube.com/watch?v=_R0DjA4sMJs
PLAYER_STATE3_DARK_LINK_IMMOBILIZEDis also used for the player, but I can't come up with a better name that would better show that both actors can have this state. "Dark Link" at least marks that it is a state specific to this fight, and that whoever is in the state is immobilized.