Automatically detect other common MIPS toolchains, update build dependencies in README#2765
Open
Thar0 wants to merge 2 commits into
Open
Automatically detect other common MIPS toolchains, update build dependencies in README#2765Thar0 wants to merge 2 commits into
Thar0 wants to merge 2 commits into
Conversation
…dencies in README
AngheloAlf
approved these changes
May 31, 2026
Dragorn421
reviewed
May 31, 2026
Comment on lines
+281
to
+284
| else ifeq ($(shell type $(N64_INST)/bin/mips64-elf-ld >/dev/null 2>/dev/null; echo $$?), 0) # libdragon | ||
| MIPS_BINUTILS_PREFIX := $(N64_INST)/bin/mips64-elf- | ||
| else ifeq ($(shell type $(N64_GCCPREFIX)/bin/mips64-elf-ld >/dev/null 2>/dev/null; echo $$?), 0) # libdragon | ||
| MIPS_BINUTILS_PREFIX := $(N64_GCCPREFIX)/bin/mips64-elf- |
Collaborator
There was a problem hiding this comment.
nit: I would put the N64_GCCPREFIX option before the N64_INST one as N64_GCCPREFIX overrides N64_INST for the purpose of binutils/gcc paths in libdragon. to rephrase, if you use libdragon and you somehow have the toolchain in both N64_GCCPREFIX and N64_INST, N64_GCCPREFIX would be used https://github.com/DragonMinded/libdragon/blob/07f1977bbb66a8f61d949983342c27915932d5a5/n64.mk#L29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.