Document EnNiwLady#2762
Open
JordanLongstaff wants to merge 8 commits into
Open
Conversation
mzxrules
reviewed
May 29, 2026
Comment on lines
+551
to
+552
| // Don't know why this is set to true here, as this talk is not about the Pocket Cucco | ||
| this->hasSpokenAboutPocketCucco = true; |
Contributor
There was a problem hiding this comment.
It's common for actors to reuse variables for when they have different state paths. Here, the variable is used for one thing when the actor is in Kakariko as an Adult, and another similar thing when the actor is in Impa's House. In the Impa's House case, the state is never read.
Contributor
Author
There was a problem hiding this comment.
One might speculate that Nintendo had intended at one point to make it possible to obtain the Pocket Cucco from talking to her in Impa's house too.
Should I remove the comment then, or rename the variable, or do something else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.