Finish EnRu1 documentation#2755
Open
JordanLongstaff wants to merge 2 commits into
Open
Conversation
Dragorn421
reviewed
May 7, 2026
| } | ||
|
|
||
| s32 func_80AED624(EnRu1* this, PlayState* play) { | ||
| s32 EnRu1_CheckSittingInWater(EnRu1* this, PlayState* play) { |
Collaborator
There was a problem hiding this comment.
this name is the only issue I have with the PR, but I don't have a suggestion
- from the name you'd expect a bool return corresponding to "is sitting in water" but that's not what the function returns
- the name doesn't capture killing the actor if
roomNum2 != curRoomNum(of which the interpretation is still unclear)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last bits of renaming/documentation. Some of it is left over from #2623. There'll need to be some discussion here on what needs to be finalized before merging (esp.
roomNum[123]).