z_player Melee attack related functions#2737
Open
djevangelia wants to merge 3 commits into
Open
Conversation
Dragorn421
reviewed
Apr 26, 2026
Comment on lines
+9182
to
+9184
| //! @bug FLOOR_TYPE_6 (no fall damage), for instance Gerudo Fortress exterior walking areas, | ||
| //! causes melee weapon to not collide properly, such as Hammer vs the Gerudo staircase | ||
| //! (continues through the floor). |
Collaborator
There was a problem hiding this comment.
are you sure this is a bug? or rather, that this is the right location for the bug comment?
it may just be that they intended for FLOOR_TYPE_6 to be "soft stuff" like hay, in which case it makes sense for attacks to go through, but then they forgot when using it on some floors
Author
There was a problem hiding this comment.
Yeah, I guess that's valid. I'd still somehow like to have it documented, that no fall damage floor type also has no melee collision. In bgcheck?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Melee functions, states etc.