Documentation pass on WaterBox code#1860
Conversation
| (((roomIndex) & 0x3F) << 13) | \ | ||
| (((isDisabled) & 1) << 19)) | ||
|
|
||
| #define WATERBOX_LIGHT_INDEX_NONE 0x1F // Generates warning when built for debug and defaults to 0 |
There was a problem hiding this comment.
In Environment_EnableUnderwaterLights in z_kankyo.c, there is a PRINTF in Ocarina that generates an error message when DEBUG_FEATURES is enabled. It is unlikely this message has been removed in og source, but it currently does not appear in MM decomp
There was a problem hiding this comment.
Ah, you mean a printf. I thought you meant a compilation warning.
I think we should word this part a bit different to avoid confusion, specially because that printf is not in this repo (yet?)
|
Contributions past, current, and future made to this repository are licensed under CC0. I couldn't find the thread, i'm in a rush. |
|
@mzxrules here's the thread: louist103/mm-licensing#1 |
hensldm
added
documentation
3 participants
As I was attempting to document the newly found waterbox bug, I found a few mistakes and improvements to make in my old documentation.
I've implemented a similar pr in Ocarina of Time, and would like there to be a consensus reached between both games before merging.
The sister PR can be found here:
zeldaret/oot#2695