x11: Improve error handling - #32913
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
mgsloan
force-pushed
the
x11-improve-error-handling
branch
2 times, most recently
from
June 18, 2025 01:20
d86066d to
9fef352
Compare
mgsloan
enabled auto-merge (squash)
June 18, 2025 01:20
Now there are only a few spots that explicitly panic, though errors during initialization will panic. Continuing this work from a while back in #21079, now greatly aided by agent + sonnet 4
mgsloan
force-pushed
the
x11-improve-error-handling
branch
from
June 18, 2025 01:22
9fef352 to
9d2c218
Compare
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Continuing this work from a while back in zed-industries#21079, now greatly aided by agent + sonnet 4. With this change, there are now only a few spots that explicitly panic, though errors during initialization will panic. Motivation was this recent user panic in `handle_event`, figured fixing all this use of unwrap was a great use of the agent. > called `Result::unwrap()` on an `Err` value: X11 GetProperty for _NET_WM_STATE failed. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing this work from a while back in #21079, now greatly aided by agent + sonnet 4. With this change, there are now only a few spots that explicitly panic, though errors during initialization will panic.
Motivation was this recent user panic in
handle_event, figured fixing all this use of unwrap was a great use of the agent.Release Notes: