Skip to content

Revert "Revert recent anti-aliasing improvements (#24289)" and fix selection top right corner radius issue - #24342

Merged
SomeoneToIgnore merged 2 commits into
zed-industries:mainfrom
huacnlee:revert-path-builder
Feb 6, 2025
Merged

Revert "Revert recent anti-aliasing improvements (#24289)" and fix selection top right corner radius issue#24342
SomeoneToIgnore merged 2 commits into
zed-industries:mainfrom
huacnlee:revert-path-builder

Conversation

@huacnlee

@huacnlee huacnlee commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

Release Notes:

  • N/A

To fix #24289 mention issue and revert PathBuilder and MSAA.

I'm sorry about of this, in #22808 I was forgotten this bit of detail.

image

So, add move_to here, we can fix the selection top right corner radius issue.

After change

image

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Feb 6, 2025
@huacnlee
huacnlee force-pushed the revert-path-builder branch from 70e7a94 to c981224 Compare February 6, 2025 02:27
@SomeoneToIgnore SomeoneToIgnore self-assigned this Feb 6, 2025

@SomeoneToIgnore SomeoneToIgnore left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for a nice improvement, and for a well-structured fix too

@SomeoneToIgnore
SomeoneToIgnore merged commit f08b1d7 into zed-industries:main Feb 6, 2025
@huacnlee
huacnlee deleted the revert-path-builder branch February 6, 2025 09:04
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…" and fix selection top right corner radius issue (zed-industries#24342)

Release Notes:

- N/A

----

To fix zed-industries#24289 mention issue and revert PathBuilder and MSAA.

I'm sorry about of this, in zed-industries#22808 I was forgotten this bit of detail.


![image](https://github.com/user-attachments/assets/112afda2-088c-41d0-83bd-808f6cd2f9d5)

So, add `move_to` here, we can fix the selection top right corner radius
issue.

## After change

<img width="1383" alt="image"
src="https://github.com/user-attachments/assets/28ea103c-d652-41d6-bbe0-7fd042d81e77"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants