gpui: Update Menu name to use SharedString type to support more types

[huacnlee]

Release Notes:

• N/A

[huacnlee]

Sorry, I meant to submit a post on my fork first, then create a discussion to see if this suggestion is accepted, but I accidentally created it here.

Let's discuss it here.

[huacnlee]

I want to change the name type of Menu because I tried to add I18n support to Zed before, and used the rust-i18n crate that I implemented. The t! method in it needs to support runtime strings (such as format!("Close all {} items", 5)), so the return value is of type Cow instead of static's str.

Here is a draft:

huacnlee#3

Or sometime we use GPUI to create app, the Menu name may be a dynamic string that created in runtime, but by current design we can't store it to Menu, so I want to change the type of Menu name to Cow.

[maxdeviant]

Have we considered using a SharedString here?

That type is more commonly used in GPUI.

[huacnlee]

SharedString is ok, it can handle same things.

[maxdeviant]

Thanks, this seems like a useful thing to have!

[huacnlee]

@maxdeviant And I have almost done the I18n support for Zed.

huacnlee#3

Are there any plans to introduce this support at this stage? After the introduction, we need to keep using t!() instead of static str for each display string. But it is simple, I also did backward compatibility. If some translate is missing, the original string will be used for display, which will not have much impact on usage.

This may increase the workload of Zed development.

[maxdeviant]

Are there any plans to introduce this support at this stage?

We haven't really discussed it internally yet, but my guess is that it's probably a ways off.

[huacnlee]

Okay, I'll put it aside for now.