Add support for haskell-debugger by rajcspsg · Pull Request #33 · zed-extensions/haskell

rajcspsg · 2026-05-11T02:16:10Z

closes #12

screen recording for debugger support

cla-bot · 2026-05-11T02:16:14Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Rajkumar Natarajan.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2026-05-11T02:26:57Z

We require contributors to sign our Contributor License Agreement, and we don't have @rajcspsg on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

rajcspsg · 2026-05-11T02:28:55Z

@cla-bot check

cla-bot · 2026-05-11T02:28:59Z

The cla-bot has been summoned, and re-checked this pull request!

MrSubidubi

Thanks for this!

Preliminary review, will do my best to get back to this in a timely manner again

MrSubidubi · 2026-05-11T16:14:32Z

Let's call this language_server.rs instead

Just wondering why this change: haskell.rs -> language_server.rs is needed.

It might be fine from Rust perspective, but by following folder structures of other Zed extension, especially with debuggers included), most extensions name its main entry file as same as the language.

Just to mention few (randomly - all with debugger support):

Ruby https://github.com/zed-extensions/ruby/tree/main/src

Java https://github.com/acardonna/java/tree/main/src

PHP https://github.com/zed-extensions/php/tree/main/src

MrSubidubi · 2026-05-11T16:14:57Z

 name = "Haskell"
 description = "Haskell support."
-version = "0.2.1"
+version = "0.2.2"


Ci will lint this, but that will be done after automatically (and will be minor at least)

Co-authored-by: Finn Evers <finn.evers@outlook.de>

rajcspsg · 2026-05-11T22:38:44Z

@MrSubidubi incorporated your review comments

MrSubidubi · 2026-06-09T10:18:11Z

Will try to get back to you with a final review this week, apologies for the delay!

sectore

Great addition. Just tested it on my local machine and it works great.

Tested manually with:

ghc --version
The Glorious Glasgow Haskell Compilation System, version 9.14.1

hdb --version
Haskell Debugger, version 0.13.1.0

zeditor --version
Zed 1.6.3

Just few nits have been added from my side.

sectore · 2026-06-21T15:40:00Z

+            format!("Invalid Haskell debug configuration (expected JSON object): {err}")
+        })?;
+    map.entry("type".to_string())
+        .or_insert_with(|| json!(HASKELL_DEBUG_ADAPTER));


(nit) or_insert_with -> or_insert

.or_insert(json!(HASKELL_DEBUG_ADAPTER));

sectore · 2026-06-21T15:41:35Z

+    map.entry("type".to_string())
+        .or_insert_with(|| json!(HASKELL_DEBUG_ADAPTER));
+    map.entry("request".to_string())
+        .or_insert_with(|| json!("launch"));


(nit) or_insert_with -> or_insert

.or_insert(json!("launch"));

sectore · 2026-06-21T15:41:57Z

+    map.entry("request".to_string())
+        .or_insert_with(|| json!("launch"));
+    map.entry("name".to_string())
+        .or_insert_with(|| json!(task.label.clone()));


(nit) or_insert_with -> or_insert

.or_insert(json!(task.label.clone()));

sectore · 2026-06-21T15:44:52Z

+fn path_components_to_string(path: &Path) -> Result<String, String> {
+    let mut out = String::new();
+    for (i, component) in path.components().enumerate() {
+        match component {
+            Component::Normal(part) => {
+                if i > 0 {
+                    out.push(std::path::MAIN_SEPARATOR);
+                }
+                out.push_str(&part.to_string_lossy());
+            }
+            Component::CurDir => {}
+            Component::ParentDir => {
+                return Err("Program path must not contain `..`.".into());
+            }
+            Component::RootDir | Component::Prefix(_) => {
+                return Err("Invalid program path.".into());
+            }
+        }
+    }
+    if out.is_empty() {
+        Err("Resolved entry file path is empty.".into())
+    } else {
+        Ok(out)
+    }
+}


(nit) path_components_to_string function can be more compact. No mutation of out: String, no loop, no if i > 0 check needed anymore.

fn path_components_to_string(path: &Path) -> Result<String, String> { path.components() .filter_map(|c| match c { Component::Normal(part) => Some(Ok(part.to_string_lossy().into_owned())), Component::CurDir => None, Component::ParentDir => Some(Err("Program path must not contain `..`.".into())), _ => Some(Err("Invalid program path.".into())), }) .collect::<Result<Vec<_>, _>>() .and_then(|parts| { if parts.is_empty() { Err("Resolved entry file path is empty.".into()) } else { Ok(parts.join(std::path::MAIN_SEPARATOR_STR)) } }) }

sectore · 2026-06-21T15:52:27Z

+        adapter_name: String,
+        config: zed::serde_json::Value,
+    ) -> Result<StartDebuggingRequestArgumentsRequest, String> {
+        crate::debugger::dap_request_kind(adapter_name.as_str(), &config)


(nit-nit) &adapter_name if you want save as_str(). Just in case :)

sectore · 2026-06-21T15:59:08Z

Just wondering why this change: haskell.rs -> language_server.rs is needed.

It might be fine from Rust perspective, but by following folder structures of other Zed extension, especially with debuggers included), most extensions name its main entry file as same as the language.

Just to mention few (randomly - all with debugger support):

Ruby https://github.com/zed-extensions/ruby/tree/main/src

Java https://github.com/acardonna/java/tree/main/src

PHP https://github.com/zed-extensions/php/tree/main/src

sectore · 2026-06-21T15:59:21Z


 [lib]
-path = "src/haskell.rs"
+path = "src/lib.rs"


see https://github.com/zed-extensions/haskell/pull/33/changes#r3448689493

sectore · 2026-06-21T16:17:31Z

+                }
+                out.push_str(&part.to_string_lossy());
+            }
+            Component::CurDir => {}


By enumerating and counting i, CurDir of ./src/Main.hs will become /src/Main.hs. Even by skipping CurDir by {}, next count of i runs Component::Normal again and adds the leading /.

That's a bug and can be fixed with a suggested change in this comment

sectore · 2026-06-22T17:43:00Z

Will try to get back to you with a final review this week, apologies for the delay!

@MrSubidubi Any chance for another review? Pls consider latest review comments.

cc/ @rajcspsg

issue-12: added support for haskell-debugger

a7133e9

rajcspsg force-pushed the haskell-debugger-support branch from c4bf776 to a7133e9 Compare May 11, 2026 02:26

cla-bot Bot added the cla-signed label May 11, 2026

MrSubidubi changed the title ~~issue-12: added support for haskell-debugger~~ Add support for haskell-debugger May 11, 2026

MrSubidubi previously approved these changes May 11, 2026

View reviewed changes

Update src/debugger.rs

4aac9e2

Co-authored-by: Finn Evers <finn.evers@outlook.de>

rajcspsg dismissed MrSubidubi’s stale review via 4aac9e2 May 11, 2026 19:49

incorporate the review comments

9b9dfcf

rajcspsg commented May 11, 2026

View reviewed changes

Comment thread Cargo.lock Outdated

rajcspsg added 2 commits May 11, 2026 13:12

version the zed-haskell version number

74f1a52

fix github actions

778b94c

Merge branch 'main' into haskell-debugger-support

8bc1e35

brandonchinn178 mentioned this pull request Jun 8, 2026

Zed Support well-typed/haskell-debugger#328

Open

Merge branch 'main' into haskell-debugger-support

27dccaf

Merge branch 'main' into haskell-debugger-support

ac61cf1

sectore approved these changes Jun 21, 2026

View reviewed changes

sectore reviewed Jun 21, 2026

View reviewed changes

Conversation

rajcspsg commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-bot Bot commented May 11, 2026

Uh oh!

cla-bot Bot commented May 11, 2026

Uh oh!

rajcspsg commented May 11, 2026

Uh oh!

cla-bot Bot commented May 11, 2026

Uh oh!

MrSubidubi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rajcspsg commented May 11, 2026

Uh oh!

MrSubidubi commented Jun 9, 2026

Uh oh!

sectore left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sectore Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sectore commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rajcspsg commented May 11, 2026 •

edited

Loading

sectore Jun 21, 2026 •

edited

Loading