chore(deps): bump github.com/gabriel-vasile/mimetype from 1.4.13 to 1.4.15 - #5140
chore(deps): bump github.com/gabriel-vasile/mimetype from 1.4.13 to 1.4.15#5140dependabot[bot] wants to merge 1 commit into
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
|
Before accepting this PR I am evaluating these based on what function they serve. This dependency is used solely by the pull logic for a package from http/https. The file has already been downloaded and we're detecting the file type extension. IMO the existing archives dependency holds better fidelity of the contract is merely .tar/.tar.zst. Otherwise the alternative would be removing the http/https pull all-together but that feels a bit extreme. Thoughts @zarf-dev/maintainers / @zarf-dev/reviewers ? |
|
@brandtkeller Yeah, I think we can replace this with the archives filetype detection It would still be an in-direct dependency, but that's a still a win IMO. |
|
Totally agree with minimizing our deps surface. |
c1b4ea7 to
9e28db3
Compare
Bumps [github.com/gabriel-vasile/mimetype](https://github.com/gabriel-vasile/mimetype) from 1.4.13 to 1.4.15. - [Release notes](https://github.com/gabriel-vasile/mimetype/releases) - [Commits](gabriel-vasile/mimetype@v1.4.13...v1.4.15) --- updated-dependencies: - dependency-name: github.com/gabriel-vasile/mimetype dependency-version: 1.4.15 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
9e28db3 to
f2b86d0
Compare
|
Closing this as the updates should now be resolved from the direct dependency. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps github.com/gabriel-vasile/mimetype from 1.4.13 to 1.4.15.
Release notes
Sourced from github.com/gabriel-vasile/mimetype's releases.
... (truncated)
Commits
f6bb955readme: add back contributing section, for #827 (#831)1b3ab2efuzz: fuzz for 32 bit too to avoid panics like #829 (#830)38e5e71cdf: fix slice index panic on 32bit arch (#829)bcd718dgedcom: add support for text/vnd.familysearch.gedcom (#789)2995287build(deps): bump the github-actions group across 1 directory with 7 updates ...14cefcbfuzz: improvements for exploring more code paths (#824)5b11e3ascan: fix panic and fuzz flags (#823)5621f29charset: stop checking for ascii if utf8 is satisfied (#768)eb8d3f4docs: mention String() can return different values (#820)9268756mkv: use IANA registered media type video/matroska (#819)