Skip to content

fix(kubeserver): delete associated credential when removing container… #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zexi merged 1 commit into from
Apr 28, 2026
Merged

fix(kubeserver): delete associated credential when removing container… #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/kubeserver/models/container_registries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,19 @@ func (r *SContainerRegistry) CustomizeCreate(ctx context.Context, userCred mccli
return nil
}

func (r *SContainerRegistry) CustomizeDelete(ctx context.Context, userCred mcclient.TokenCredential, query jsonutils.JSONObject, data jsonutils.JSONObject) error {
if r.CredentialId != "" {
s, err := GetAdminSession()
if err != nil {
return errors.Wrap(err, "get admin session")
}
if _, err := identitymodules.Credentials.Delete(s, r.CredentialId, nil); err != nil {
return errors.Wrapf(err, "delete credential %s", r.CredentialId)
}
}
return r.SSharableVirtualResourceBase.CustomizeDelete(ctx, userCred, query, data)
}

func (r *SContainerRegistry) GetConfig() (*api.ContainerRegistryConfig, error) {
if r.Config != nil {
conf := new(api.ContainerRegistryConfig)
Expand Down
Loading