Hide SNMP secrets for Procurve - #3774
Open
iriseden wants to merge 2 commits into
Open
Conversation
iriseden
marked this pull request as ready for review
March 20, 2026 19:22
iriseden
marked this pull request as draft
March 31, 2026 19:17
iriseden
marked this pull request as ready for review
April 1, 2026 16:26
Collaborator
|
Note while reviewing PRs: The issue in the PR is still not fixed, missing CHANGELOG.md |
4 tasks
thanegill
added a commit
to thanegill/oxidized
that referenced
this pull request
Jun 10, 2026
…ecrets The :secret rule only covered SNMP communities, sha1 password hashes, and RADIUS/TACACS+ keys. With include-credentials (and encrypt-credentials) the running-config can also carry SNMPv3 auth/priv passwords, plaintext/sha256 and encrypted-password local passwords, RADIUS/TACACS+ encrypted-key (resolves ytti#3774, key-chain key material, 802.1X supplicant secrets, SNTP authentication keys, the MACsec pre-shared CAK, and the encrypt-credentials master pre-shared-key. Redact all of them (drawn from the ArubaOS-Switch Access Security Guide). Add two synthetic fixtures, one per mutually-exclusive mode, covering the cleartext/hashed and encrypted- forms respectively. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
thanegill
added a commit
to thanegill/oxidized
that referenced
this pull request
Jun 10, 2026
…ecrets The :secret rule only covered SNMP communities, sha1 password hashes, and RADIUS/TACACS+ keys. With include-credentials (and encrypt-credentials) the running-config can also carry SNMPv3 auth/priv passwords, plaintext/sha256 and encrypted-password local passwords, RADIUS/TACACS+ encrypted-key (resolves ytti#3774), key-chain key material, 802.1X supplicant secrets, SNTP authentication keys, the MACsec pre-shared CAK, and the encrypt-credentials master pre-shared-key. Redact all of them (drawn from the ArubaOS-Switch Access Security Guide). Add two synthetic fixtures, one per mutually-exclusive mode, covering the cleartext/hashed and encrypted- forms respectively. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Hide SNMP secrets for Procurve