[Backport 4.0] Fix Bootstrap on Centos 7 on GCP fails

[loicalbertin]

Pull Request description

Description of the change

What I did

Update bootstrap tosca types with Forge PR ystia/forge#132

How to verify it

Bootstrap on with centos7 GCP

Description for the changelog

• Bootstrap on Centos 7 on GCP fails (GH-649)

Applicable Issues

Fixes #649

Backports

Backport of #650

[laurentganne]

Seeing this error during the bootstrap, will have a look:

    The task includes an option with an undefined variable. The error was: the inline if-expression on line 1 evaluated to false and no else section was defined.

    The error appears to have been in '/home/yorcuser/bootstrap/work/deployments/testtmp/overlay/org.ystia.ansible.linux.ansible/2.2.0-SNAPSHOT/playbooks/create.yml': line 59, column 7, but may
    be elsewhere in the file depending on the exact syntax problem.

    The offending line appears to be:


        - name: install Ansible using Pip
          ^ here

[loicalbertin]

Also note that I have to document that epel repositories on Centos are now required for bootstrap Yorc.
That said it seems to work on CI.

[laurentganne]

The issue should be in org/ystia/ansible/linux/ansible/playbooks/create.yml
at :

extra_args: "{{ '--extra-index-url {}'.format(ANSIBLE_EXTRA_PACKAGE_REPOSITORY) if ANSIBLE_EXTRA_PACKAGE_REPOSITORY != ''}}"

Adding a else seems to fix the issue,
when using this definition for extra_args, it works:

extra_args: "{{ '--extra-index-url {}'.format(ANSIBLE_EXTRA_PACKAGE_REPOSITORY) if ANSIBLE_EXTRA_PACKAGE_REPOSITORY != ''  else ''}}"

[loicalbertin]

Ok will add this but should be somehow dependent on a 3thd party lib as I tested it and it worked for me

[loicalbertin]

Could you please port this change to the forge too?
Thanks

[laurentganne]

Ok will add this but should be somehow dependent on a 3thd party lib as I tested it and it worked for me

I just pushed the change. Yes, I didn't find what in my setup produced a different behavior. This is a CentOS 7.8.2003 GCP VM created several months ago to perform bootstraps.

[laurentganne]

Could you please port this change to the forge too?
Thanks

yes, will do

[laurentganne]

Looks good! 👍

[laurentganne]

Looks good!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here