[FEAT] 코스 후기 API 응답 변경 반영 - #263
Merged
Merged
Conversation
- ReviewCourse에 추가된 courseType을 매퍼에서 그대로 넘김 - 라우트 판별용 코스 상세 선조회(useNavigateToCourseDetail) 제거 - 이동수단 라벨 prop 이름을 transport로 바로잡아 코스 타입과 구분
develop의 찜 목록이 useNavigateToCourseDetail을 쓰기 시작했다. LikedResponse에는 courseType이 없어 선조회가 필요하다. 후기는 응답에 courseType이 있어 계속 buildCourseDetailPath로 바로 이동한다.
- 코스별 후기 응답이 imageUrls에서 images(imageKey 포함)로 바뀐 것을 반영 - 코스 상세와 후기 전체보기에서 막아 뒀던 수정 진입을 연다 - 작성자 메타에 성별을 붙여 20대 여 형태로 표시
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthrough리뷰 응답의 이미지, 성별, 코스 타입 필드를 새 스키마에 맞게 반영했습니다. 홈, 최근 후기, 코스 상세, 후기 전체보기 화면에 리뷰 수정 진입과 코스 상세 이동을 연결했습니다. Changes리뷰 응답 계약과 이미지 매핑
리뷰 수정 진입 연결
코스 라우팅과 리뷰 카드 계약
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant ReviewCard
participant ReviewPage
participant useReviewEdit
participant ReviewEditModal
ReviewCard->>ReviewPage: onEditClick(review)
ReviewPage->>useReviewEdit: requestEdit(review)
useReviewEdit-->>ReviewPage: editorProps
ReviewPage->>ReviewEditModal: editorProps 전달
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/hooks/useReviews.ts`:
- Around line 251-255: Update the comment above the review-edit hook usage to
state that editing is supported from home, recent reviews, course detail, and
the full review view; remove the outdated claim that course review lists lack
imageKey and cannot identify retained photos. Keep the implementation unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f69dfd86-48c9-442e-a0c1-1f5628493572
📒 Files selected for processing (16)
src/components/common/CourseReviewCard.tsxsrc/components/common/ReviewEditModal.tsxsrc/hooks/useCourses.tssrc/hooks/useReviews.tssrc/pages/course-reviews/index.tsxsrc/pages/detail/components/CourseDetailLayout.tsxsrc/pages/detail/components/DetailReviewSection.tsxsrc/pages/detail/constants/courseDetailMock.tssrc/pages/detail/mappers/courseReviewMapper.tssrc/pages/detail/types/courseDetail.tssrc/pages/home/components/ReviewSection.tsxsrc/pages/recent-review-courses/index.tsxsrc/types/review.type.tssrc/utils/reviewCard.tstests/course-review-mapper.test.tstests/review-card-mapper.test.ts
📜 Review details
🧰 Additional context used
🧠 Learnings (6)
📚 Learning: 2026-07-26T17:09:23.387Z
Learnt from: KJun-2
Repo: yeogido/frontend PR: 125
File: src/pages/local-recommendation/course-basic-info/components/CompanionSelector.tsx:82-90
Timestamp: 2026-07-26T17:09:23.387Z
Learning: 이 프로젝트의 반응형 스케일 정책에서는 텍스트(폰트) 크기를 설계 기준 값에 전역 `scale`을 곱해 비율대로 스케일하세요. `12px`, `14px`처럼 특정 최소 하한을 강제로 적용하거나(클램프/바닥값) 임의의 픽셀 값으로 제한하지 마세요. 즉, 기준값(디자인 스펙) × `scale` 방식으로 계산해 비율이 유지되도록 구현합니다.
Applied to files:
src/components/common/ReviewEditModal.tsxsrc/pages/detail/components/CourseDetailLayout.tsxsrc/components/common/CourseReviewCard.tsxsrc/pages/home/components/ReviewSection.tsxsrc/pages/course-reviews/index.tsxsrc/pages/recent-review-courses/index.tsxsrc/pages/detail/components/DetailReviewSection.tsx
📚 Learning: 2026-08-03T09:41:11.931Z
Learnt from: KJun-2
Repo: yeogido/frontend PR: 188
File: src/pages/detail/components/CourseDetailLayout.tsx:202-205
Timestamp: 2026-08-03T09:41:11.931Z
Learning: When implementing the shared back-navigation UI component in yeogido/frontend, manage all UI dimensions, including positional offsets, according to the project’s global `scale` policy so the component remains visually consistent across screens.
Applied to files:
src/components/common/ReviewEditModal.tsxsrc/pages/detail/components/CourseDetailLayout.tsxsrc/components/common/CourseReviewCard.tsxsrc/pages/home/components/ReviewSection.tsxsrc/pages/course-reviews/index.tsxsrc/pages/recent-review-courses/index.tsxsrc/pages/detail/components/DetailReviewSection.tsx
📚 Learning: 2026-07-26T17:09:27.685Z
Learnt from: KJun-2
Repo: yeogido/frontend PR: 125
File: src/pages/local-recommendation/course-basic-info/components/TransportSelector.tsx:84-91
Timestamp: 2026-07-26T17:09:27.685Z
Learning: In this project’s 390px-based continuous responsive scaling, do not apply an artificial minimum lower bound to text sizes (e.g., avoid clamping via Math.max/min-font-size patterns). Instead, compute typography using proportional ratio scaling: render font sizes as `VALUE * scale` (for example, `DESCRIPTION_FONT_SIZE * scale`). During review, flag any code that enforces a hard minimum text size that breaks the intended proportional scaling.
Applied to files:
src/components/common/ReviewEditModal.tsxsrc/pages/detail/components/CourseDetailLayout.tsxsrc/components/common/CourseReviewCard.tsxsrc/pages/home/components/ReviewSection.tsxsrc/pages/course-reviews/index.tsxsrc/pages/recent-review-courses/index.tsxsrc/pages/detail/components/DetailReviewSection.tsx
📚 Learning: 2026-07-26T17:09:32.991Z
Learnt from: KJun-2
Repo: yeogido/frontend PR: 125
File: src/pages/local-recommendation/tag-selection/components/KeywordSelectionSection.tsx:51-56
Timestamp: 2026-07-26T17:09:32.991Z
Learning: When implementing responsive scaling in this project, prefer direct proportional calculations (e.g., using `VALUE * scale`) without applying artificial minimum lower bounds (clamps) to text sizes or other visual dimensions. Only introduce a lower bound when there is an explicitly documented exception; the primary allowed example is enforcing a 44px minimum touch target for interactive elements. In review, flag new/minimum clamps for text/visual dimensions unless they match an explicitly documented exception.
Applied to files:
src/components/common/ReviewEditModal.tsxsrc/pages/detail/components/CourseDetailLayout.tsxsrc/components/common/CourseReviewCard.tsxsrc/pages/home/components/ReviewSection.tsxsrc/pages/course-reviews/index.tsxsrc/pages/recent-review-courses/index.tsxsrc/pages/detail/components/DetailReviewSection.tsx
📚 Learning: 2026-07-26T17:09:40.303Z
Learnt from: KJun-2
Repo: yeogido/frontend PR: 125
File: src/pages/local-recommendation/tag-selection/components/RepresentativePhotoSection.tsx:107-122
Timestamp: 2026-07-26T17:09:40.303Z
Learning: yeogido/frontend의 반응형 스케일 정책에 맞춰, 텍스트를 포함한 UI 치수는 (디자인 기준값) × 전역 `scale`로 “연속적으로” 계산하고, 12px·14px 같은 최소 폰트/사이즈 하한(floor) 클램프를 적용하지 않는다. `scaleValue`를 쓰더라도 텍스트에 임의의 minimum floor를 추가하거나 `Math.max(value, 12/14)` 같은 보정을 넣지 말 것.
Applied to files:
src/components/common/ReviewEditModal.tsxsrc/pages/detail/components/CourseDetailLayout.tsxsrc/components/common/CourseReviewCard.tsxsrc/pages/home/components/ReviewSection.tsxsrc/pages/course-reviews/index.tsxsrc/pages/recent-review-courses/index.tsxsrc/pages/detail/components/DetailReviewSection.tsx
📚 Learning: 2026-07-09T14:49:12.548Z
Learnt from: kimtaehyeokkkk
Repo: yeogido/frontend PR: 18
File: src/components/common/ReviewCard.tsx:21-36
Timestamp: 2026-07-09T14:49:12.548Z
Learning: In `FestivalSection.tsx`, `CourseSection.tsx`, and `ReviewSection.tsx` under `src/pages/home/components/`, keep the local `isLoading` toggle as an intentional UI-only control for verifying skeleton/placeholder states. Do not flag `isLoading` as an issue for not being derived from real data fetching until the planned React Query migration; only raise concerns if the toggle is misused in a way that breaks the UI (e.g., it doesn’t control the intended skeleton/placeholder rendering or is clearly dead/unused code).
Applied to files:
src/pages/home/components/ReviewSection.tsx
🔇 Additional comments (15)
src/types/review.type.ts (1)
17-24: LGTM!Also applies to: 68-76, 116-119
src/utils/reviewCard.ts (1)
14-14: LGTM!Also applies to: 24-26, 54-54, 71-71, 80-80
src/pages/detail/mappers/courseReviewMapper.ts (1)
2-2: LGTM!Also applies to: 20-21
src/pages/detail/types/courseDetail.ts (1)
21-22: LGTM!src/pages/detail/constants/courseDetailMock.ts (1)
68-68: LGTM!Also applies to: 79-79
tests/course-review-mapper.test.ts (1)
6-55: LGTM!Also applies to: 71-82, 97-100
src/components/common/ReviewEditModal.tsx (1)
106-107: LGTM!src/pages/course-reviews/index.tsx (1)
10-10: LGTM!Also applies to: 23-23, 101-101, 215-215, 240-241
src/pages/detail/components/CourseDetailLayout.tsx (1)
25-25: LGTM!Also applies to: 38-38, 125-125, 339-339, 360-361
src/pages/detail/components/DetailReviewSection.tsx (1)
30-30: LGTM!Also applies to: 40-40, 141-143
src/components/common/CourseReviewCard.tsx (1)
24-25: LGTM!Also applies to: 48-48, 88-88
src/hooks/useCourses.ts (1)
108-112: LGTM!Also applies to: 127-135, 167-167
src/pages/home/components/ReviewSection.tsx (1)
12-13: LGTM!Also applies to: 21-21, 46-49, 164-164, 209-209
src/pages/recent-review-courses/index.tsx (1)
2-2: LGTM!Also applies to: 13-13, 27-27, 57-59, 75-78, 167-167, 187-187, 205-205
tests/review-card-mapper.test.ts (1)
13-19: LGTM!Also applies to: 51-66, 77-81
코스별 후기 응답에도 imageKey가 오면서 네 화면 모두 수정에 들어갈 수 있게 됐는데, 두 곳에만 있다고 설명하는 주석이 남아 있었다.
yoonsunmindd
approved these changes
Aug 6, 2026
yoonsunmindd
left a comment
yoonsunmindd
left a comment
Contributor
There was a problem hiding this comment.
화면 다 확인 했습니다! 수고하셨습니다
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
imageUrls→images).imageKey·imageOrder가 함께 와서 전체 후기 목록과 모양이 같아졌습니다imageKey가 없어 유지할 사진을 지목할 수 없던 제약이 풀렸습니다courseType으로 코스 상세 경로를 정하도록 변경. 라우트 판별용 선조회를 제거해 카드 탭 시 네트워크 왕복이 사라졌습니다courseType→transport로 정정(새로 생긴 코스 타입과 이름이 겹쳤습니다)변경 화면
/홈 최근 후기/recent-review-courses최근 후기/{yeogido|local}-course/detail/:courseId코스 상세 후기 미리보기/{yeogido|local}-course/detail/:courseId/reviews후기 전체보기확인 방법
/yeogido-course/detail/:id, 동네 코스 후기 카드 탭 →/local-course/detail/:id로 가는지 확인/likes)에서 코스 카드 탭 시 이동이 그대로 되는지 확인체크리스트
스크린샷
참고 사항
useNavigateToCourseDetail을 지웠다가 되살렸습니다. 후기 응답에courseType이 생겨 필요 없어졌는데, develop에서 머지된 찜 목록(#252)이 이 훅을 쓰기 시작했습니다.LikedResponse에는courseType이 없어 선조회가 실제로 필요해서 되살렸고, 어느 쪽을 써야 하는지 주석에 적어 뒀습니다. 찜 목록 페이지 자체는 건드리지 않았습니다.courseDetailMock.ts에 필드 하나를 추가했습니다. 죽은 코드지만 타입 체크에 걸려서 빌드를 위해 필요했습니다. 정리는 별도 작업이 맞다고 봅니다.관련 이슈
Closes #262
Summary by CodeRabbit