Fix EINVAL on sendto() after recvmsg() on FreeBSD 15#126
Open
zhmylove wants to merge 1 commit into
Open
Conversation
On FreeBSD 15, sendto() validates that sockaddr_len matches the address family. After recvmsg(), addrlen was still set to sizeof(struct sockaddr_storage) (128 bytes) instead of the actual length (16 for IPv4), causing EINVAL on every DNS reply. Fix by reading the real sockaddr length from msg.msg_namelen after recvmsg(), guarded by __FreeBSD__ to avoid unnecessary change on other platforms. Signed-off-by: Sergei Zhmylev <zhmylove@narod.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On FreeBSD 15, sendto() validates that sockaddr_len matches the address family. After recvmsg(), addrlen was still set to sizeof(struct sockaddr_storage) (128 bytes) instead of the actual length (16 for IPv4), causing EINVAL on every DNS reply.
Fix by reading the real sockaddr length from msg.msg_namelen after recvmsg(), guarded by FreeBSD to avoid unnecessary change on other platforms.