Alternative Python multiprocessing implementation#2
Open
jzavatoneveth wants to merge 4 commits into
Open
Conversation
added 4 commits
April 26, 2018 20:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a possible alternate implementation of the multiprocessing code that should not drop temperature steps. It has the distinct disadvantage of storing all the data from each run in main memory before writing it to disk once all temperatures are finished. However, I think that there may be some advantages to using
multiprocessing.Pool.mapwith apartial()-frozen version of the simulation function in terms of code readability, performance, and stability (i.e. not dropping temperatures). I think it should be possible to add the real-time saving back to this variant. If I recall correctly, using theloggingmodule may be the most stable way to do so.In addition, the temperature list is now constructed with an admittedly more verbose pure Python expression rather than
numpy.arange, but should not have the floating point round-off issues thatarangeexhibits (Fromhttps://docs.scipy.org/doc/numpy/reference/generated/numpy.arange.html: "When using a non-integer step, such as 0.1, the results will often not be consistent. It is better to use linspace for these cases.")