Skip to content

bgfx: update to 8889#9773

Open
rempas wants to merge 2 commits intoxmake-io:devfrom
rempas:rempas-bgfx
Open

bgfx: update to 8889#9773
rempas wants to merge 2 commits intoxmake-io:devfrom
rempas:rempas-bgfx

Conversation

@rempas
Copy link
Copy Markdown
Contributor

@rempas rempas commented Apr 17, 2026

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 8889 to the bgfx package and removes version 7816. Feedback identifies orphaned resource entries for the removed version that should be cleaned up and suggests maintaining a consistent sort order for versions and resources to improve readability.

Comment thread packages/b/bgfx/xmake.lua
set_license("BSD-2-Clause")

add_urls("https://github.com/bkaradzic/bgfx.git")
add_versions("7816", "5ecddbf4d51e2dda2a56ae8cafef4810e3a45d87")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Version 7816 has been removed from the add_versions list, but its corresponding add_resources entries for bx and bimg (lines 15 and 21 in the updated file) are still present. These should be removed to keep the package definition clean and avoid maintaining unreachable resource configurations.

Comment thread packages/b/bgfx/xmake.lua
add_urls("https://github.com/bkaradzic/bgfx.git")
add_versions("7816", "5ecddbf4d51e2dda2a56ae8cafef4810e3a45d87")

add_versions("8889", "4cc041f59f90fee9272ca9b57b292e2c23df1c69")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version list is now inconsistently ordered (8889 followed by 8203, 8674, 8752). It is recommended to maintain a consistent sort order (e.g., descending) for both add_versions and add_resources blocks to improve maintainability and readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant