Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Pulsar C++ client package to version 4.1.0. Feedback indicates that starting from version 4.0.0, Boost is no longer a required dependency; therefore, the package configuration should be updated to reflect this change to optimize build times and reduce unnecessary dependencies.
|
|
||
| add_urls("https://github.com/apache/pulsar-client-cpp/archive/refs/tags/v$(version).tar.gz") | ||
|
|
||
| add_versions("4.1.0", "172c9697caf62551c336e0bf64a136ccdff0674e9ea66f94f3f60962c5d41958") |
Contributor
There was a problem hiding this comment.
Starting with version 4.0.0, the Pulsar C++ client has removed its dependency on Boost. Since this PR updates the package to version 4.1.0, the add_deps section (line 14) should be updated to make Boost optional or remove it for version 4.0.0 and later. This will significantly reduce build times and avoid unnecessary dependencies for users of the new version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of pulsar detected (package version: 3.6.0, last github version: 4.1.0)