Skip to content

ObjFW should use openssl3 for dep #9749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Frityet wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

ObjFW should use openssl3 for dep #9749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c00164
should use opnssl3 for dep
Frityet Apr 14, 2026
d83fd49
Refactor TLS config and update SSL dependencies
Frityet Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/o/objfw/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,21 +75,18 @@ package("objfw")
add_configs("arc", { description = "Enable Automatic Reference Counting (ARC) support.", default = true, type = "boolean" })

on_load(function (package)
if package:is_plat("macosx") and package:version() and package:version():gt("1.4.4") and package:config("tls") == "securetransport" then
package:config_set("tls", "openssl")
end
local tls = package:config("tls")
if type(tls) == "boolean" then
if tls then
if package:is_plat("macosx") then
package:add("frameworks", "Security")
else
package:add("deps", "openssl")
package:add("deps", "openssl3")
end
end
elseif tls then
if tls == "openssl" then
package:add("deps", "openssl")
package:add("deps", "openssl3")
Comment thread
Frityet marked this conversation as resolved.
elseif tls == "securetransport" then
package:add("frameworks", "Security")
elseif tls == "gnutls" then
Expand Down Expand Up @@ -134,7 +131,7 @@ package("objfw")

-- SecureTransport must be handled by system so we don't worry about providing CFLAGS and LDFLAGS,
-- but for OpenSSL and GnuTLS we need to provide the paths
local ssl = package:dep("openssl") or package:dep("gnutls")
local ssl = package:dep("openssl3") or package:dep("gnutls") or package:dep("openssl")
local is_gnu = ssl and ssl:name() == "gnutls"
if ssl then
import("lib.detect.find_library")
Expand All @@ -150,8 +147,6 @@ package("objfw")
if libssl then
table.insert(configs, "CPPFLAGS=-I" .. ssl_incdir)
table.insert(configs, "LDFLAGS=-L" .. libssl.linkdir)
else
print("No SSL library found, using system default")
end
end

Expand Down
Loading