Skip to content

Add support for LLVM version 21.1.0#9747

Merged
waruqi merged 5 commits intoxmake-io:devfrom
ArthurVasseur:llvm21.1
May 1, 2026
Merged

Add support for LLVM version 21.1.0#9747
waruqi merged 5 commits intoxmake-io:devfrom
ArthurVasseur:llvm21.1

Conversation

@ArthurVasseur
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for LLVM version 21.1.0 and introduces x86 architecture configurations for the libllvm package. Several critical issues were identified, including a Lua syntax error using "else if" instead of "elseif", a missing download URL for the x86 architecture, and the use of an invalid LLVM version with an empty string hash and non-existent git tag.

Comment thread packages/l/libllvm/xmake.lua Outdated
Comment thread packages/l/libllvm/xmake.lua Outdated
Comment thread packages/l/libllvm/xmake.lua Outdated
@ArthurVasseur ArthurVasseur force-pushed the llvm21.1 branch 9 times, most recently from b3ce0a7 to 8619ff7 Compare April 16, 2026 09:45
@ArthurVasseur ArthurVasseur force-pushed the llvm21.1 branch 3 times, most recently from fc29e43 to 01dd806 Compare April 18, 2026 11:54
@ArthurVasseur
Copy link
Copy Markdown
Contributor Author

The ubuntu build is passing if I am using act
image

The CI is not powerful enough

Comment thread .github/workflows/iphoneos.yml Outdated
@waruqi
Copy link
Copy Markdown
Member

waruqi commented Apr 22, 2026

The ubuntu build is passing if I am using act image

The CI is not powerful enough

Due to CI's resource limitations, I will manually merge it once your local testing and verification are successful.

@ArthurVasseur
Copy link
Copy Markdown
Contributor Author

FreeBSD static build is working
image

@ArthurVasseur
Copy link
Copy Markdown
Contributor Author

Could not test on Apple-based systems or ARM-based operating systems

@luadebug
Copy link
Copy Markdown
Member

luadebug commented Apr 24, 2026

Maybe we can try macos-15 for ios builder but I am not sure it would be faster. As it says M1/M2 it would probably be same M1 as macos-14 and 7GB ram.
Placing -j1 directly inside of YML workflow for iOS to avoid OOM did not help, it still occur OOM. :(

waruqi added 2 commits April 24, 2026 23:24
Removed the '-j1' option from the xmake test command.
@ArthurVasseur
Copy link
Copy Markdown
Contributor Author

What should we do here?

@luadebug
Copy link
Copy Markdown
Member

luadebug commented May 1, 2026

Maybe we can improve existing runners but this would be very hard to achieve as we can try increase SWAP size https://github.com/marketplace/actions/maximize-build-disk-space

@waruqi waruqi merged commit 5ceb59c into xmake-io:dev May 1, 2026
39 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants