Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a legacy version (v2016-04) of the or-tools package. However, placing it at the top of the version list incorrectly sets it as the default version in xmake, and it is likely incompatible with the current build scripts and tests.
| add_urls("https://github.com/google/or-tools/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/google/or-tools.git") | ||
|
|
||
| add_versions("v2016-04", "6983b7b640125570ad342416a9aa25aaa715454fe022e05501c205583ab3106b") |
Contributor
There was a problem hiding this comment.
The version v2016-04 is a legacy release from 2016 and is not an update over v9.15. In xmake, the first version in add_versions is the default; adding this at the top incorrectly downgrades the package. Additionally, the current build script and tests are designed for modern CMake-based versions and will fail with this version. This addition should be removed or moved to the end of the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of or-tools detected (package version: v9.15, last github version: v2016-04)