Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for HPX version 1.11.0. Feedback indicates that the package configuration needs to be updated to require a C++20 compliant compiler and asio version 1.30.0 or higher to ensure compatibility with this new release.
| add_urls("https://github.com/STEllAR-GROUP/hpx/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/STEllAR-GROUP/hpx.git") | ||
|
|
||
| add_versions("v1.11.0", "01ec47228a2253b41e318bb09c83325a75021eb6ef3262400fbda30ac7389279") |
Contributor
There was a problem hiding this comment.
HPX v1.11.0 requires a C++20 compliant compiler and asio >= 1.30.0. The current package configuration uses c++17 in the on_test block (line 61) and specifies asio >= 1.12.0 (line 26). These requirements should be updated to ensure compatibility with the new version, as the current settings will likely lead to compilation failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of hpx detected (package version: v1.10.0, last github version: v1.11.0)