Skip to content

Fix negative bodysize leading to heap overflow in ogg_stream_pagein #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MH1983-web wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix negative bodysize leading to heap overflow in ogg_stream_pagein #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/framing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,14 @@ int ogg_stream_pagein(ogg_stream_state *os, ogg_page *og){
}
}

/* bodysize is derived from og->body_len minus the sum of the
skipped continued-packet lacing values above. A page whose
segment table is inconsistent with body_len can drive this
negative; passing a negative long to memcpy's size_t parameter
would request an enormous copy and overflow the body buffer.
Reject such pages defensively. */
if(bodysize<0) return -1;

if(bodysize){
if(_os_body_expand(os,bodysize)) return -1;
memcpy(os->body_data+os->body_fill,body,bodysize);
Expand Down