ltoplugin: analyze MethodByName names through bounded loops#2126
Merged
Conversation
zhouguangyuan0718
marked this pull request as ready for review
July 19, 2026 11:25
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
zhouguangyuan0718
marked this pull request as draft
July 19, 2026 12:07
zhouguangyuan0718
force-pushed
the
main-lto-string-loop
branch
from
July 19, 2026 15:40
a2d139a to
69054c1
Compare
zhouguangyuan0718
marked this pull request as ready for review
July 19, 2026 23:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rangevalues[...]string{const...}range cases in the LTO testsThe local composite literal case was not handled before because ABI lowering produced a local string array initialized by constant stores, while the pass only folded loads from global initializers.
Validation
TestBuildAndCheckSymbolsFromTestltoLTOPluginTestRunAndTestFromTestltoLTOPluginBoth pass with the rebuilt LTO plugin, and the new test confirms that
Query,Mutation, andSubscriptionare retained whileDropis eliminated.