Skip to content

Add renditions to docker-compose subproject [ACC-3063] - #1630

Open
rschev wants to merge 5 commits into
mainfrom
compose-renditions
Open

Add renditions to docker-compose subproject [ACC-3063]#1630
rschev wants to merge 5 commits into
mainfrom
compose-renditions

Conversation

@rschev

@rschev rschev commented Sep 1, 2026

Copy link
Copy Markdown
Member

No description provided.

@rschev
rschev requested a review from a team as a code owner September 1, 2026 06:02
@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

@AndreasVAmexio AndreasVAmexio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two suggestions are fixes. The question about the dlx is likely also a bug.

{
"vhost": "/",
"name": "renditions-responses",
"pattern": "^renditions-responses$",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The queue name is rendition(singular) -responses.

Suggested change
"pattern": "^renditions-responses$",
"pattern": "^rendition-responses$",

},
{
"vhost": "/",
"name": "renditions-responses",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The queue name is rendition(singular) -responses.

Suggested change
"name": "renditions-responses",
"name": "rendition-responses",

{
"name": "renditions-dlx",
"vhost": "/",
"type": "fanout",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this dead letter exchange route to anything? I see no binding for this exchange.

@AndreasVAmexio AndreasVAmexio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two non-blocking requests.


# Set up normal/dead letter exchange, request/response queues, bindings
renditions-rabbitmq-bootstrap:
image: ghcr.io/xenit-eu/kubectl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pin the image version?

environment:
RABBITMQ_PASSWORD: $RABBITMQ_PASSWORD
volumes:
- ./bootstrap/renditions-rabbitmq:/tmp/rabbitmq

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this mount be ro, like the other mounts?

Suggested change
- ./bootstrap/renditions-rabbitmq:/tmp/rabbitmq
- ./bootstrap/renditions-rabbitmq:/tmp/rabbitmq:ro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants