ALFREDAPI-585: Add create with id (for CG rollback mechanism) - #267
Merged
Conversation
WimCrols
changed the title
WimCrols
force-pushed
the
ALFREDAPI-585_ethiasrollback-createwithid
branch
from
June 10, 2026 13:56
1ba65e7 to
96dc593
Compare
WimCrols
force-pushed
the
ALFREDAPI-585_ethiasrollback-createwithid
branch
from
June 15, 2026 14:25
22e0a11 to
1d851f4
Compare
WimCrols
marked this pull request as ready for review
June 16, 2026 06:56
WimCrols
force-pushed
the
ALFREDAPI-585_ethiasrollback-createwithid
branch
from
June 16, 2026 07:12
1d851f4 to
2454504
Compare
Brobrechts
reviewed
Jun 17, 2026
Brobrechts
reviewed
Jun 17, 2026
Brobrechts
reviewed
Jun 17, 2026
Brobrechts
left a comment
Brobrechts
left a comment
Contributor
There was a problem hiding this comment.
In general this looks good, I presume most is cherry picked from future and fixes the harbor things (all fine)
The java 21 JDK, should be fine if the specific versions respect the toolchain.
This one also only releases > 7.4 versions looking at build.gradle
Brobrechts
reviewed
Jun 18, 2026
Brobrechts
reviewed
Jun 18, 2026
Brobrechts
approved these changes
Jun 23, 2026
Brobrechts
left a comment
Brobrechts
left a comment
Contributor
There was a problem hiding this comment.
As discussed with Wim crols.
This is also isolated to 7x to keep it buildable.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Note the base branch: we merge into master-5.x
Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-585
Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
@Qualifier("ServiceRegistry")?@ExceptionHandlerin the webscript classes?this.prefix avoided?See README.md for full explanation.