-
Notifications
You must be signed in to change notification settings - Fork 158
feat: subscriptions overhaul #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
ac23b65
wip: subs v2
endigma 5d43982
wip: error handling improvements
endigma a5e12fb
collapse adapter readloop into a handler system instead of channels
endigma 2a3e4f6
add serena config
endigma 4c8ddc3
fix review issues
endigma e910880
simplify connection and transport construction
endigma 9759685
fix lint issue
endigma cb2348a
add idle timeout before closing unused connections
endigma d78d83c
restore backwards compatible errors
endigma 4cc007c
remove unused test helper
endigma 3eb0a1b
remove serena from git
endigma 33bca4c
remove redundant switch in subscription client factory
endigma e986f34
Fix SSE header apply order
endigma 4fd554f
fix defer
endigma 54060a2
fix timeout default check
endigma 76e9d07
allow pongs during init
endigma 162135c
nil check in withlogger
endigma 914d974
fixup tests to be clearer
endigma 95ea70e
remove finalizer abstraction
endigma 13ccb44
go mod tidy in execution
endigma 9d2cbd1
Error implementation for EngineResultWriter
endigma 825d611
clarify protocol being implemented
endigma f949b24
clean up timeout default placement
endigma 3879306
renaming message types for clarity, adding doc comments to protocol
endigma 3412101
lighter ints for enums
endigma fb6d012
use consts directly in map function
endigma 6e167e2
clarify re-export file
endigma cf2504b
fix toctou race and add a test
endigma 0a28c72
move filter buffer handling inside, use pool
endigma 83073b0
doc comments improvement
endigma 039b62d
clean up complicated 3/4 value returns
endigma 1f492df
resolver method renaming and cleanup
endigma 1336b63
clean up locking a bit
endigma 9ce6cd2
reusable helpers for filtering and snapshotting and getting to make
endigma 6c54a76
more comments, rename misleading resolver field, encapsulate writer
endigma 3e77211
Merge branch 'master' into jesse/eng-8566-new-subscription-client
endigma 7d96ff2
fix gci
endigma e37eeb1
comments and connection ids
endigma 8ea3957
fix: issue with legacy ws not being pingable
endigma 8367e22
use default error extension config
endigma 8d98128
refactor: rename connectionIDs to connectionIDCounter
endigma 7725628
refactor: unexport protocol types, remove trivial getter
endigma a198549
docs: fix stale comments on handleTriggerUpdate
endigma ca18a45
fix: broadcast Source.Start() error to all trigger subscribers
endigma af90771
fix: broadcast trigger startup errors to all subscribers
endigma a13b074
chore: Handle WS and invalid transport
endigma d237e3c
fix(sse): remove SSEMethodAuto
endigma aef088f
refactor: consolidate defaults to the client
endigma c5b06d9
refactor: unexport subscription client config
endigma 9c9bb10
docs: Add comment for ErrClientClosed
endigma f98e29c
sse: simplify line splitting
endigma 7e7d60c
review comments
endigma 03de100
document maps in wstransport
endigma fd0879f
Merge branch 'master' into jesse/eng-8566-new-subscription-client
endigma e541ed5
Merge branch 'master' into jesse/eng-8566-new-subscription-client
endigma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| /cache | ||
| /project.local.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| # the name by which the project can be referenced within Serena | ||
| project_name: "graphql-go-tools" | ||
|
endigma marked this conversation as resolved.
Outdated
|
||
|
|
||
|
|
||
| # list of languages for which language servers are started; choose from: | ||
| # al bash clojure cpp csharp | ||
| # csharp_omnisharp dart elixir elm erlang | ||
| # fortran fsharp go groovy haskell | ||
| # java julia kotlin lua markdown | ||
| # matlab nix pascal perl php | ||
| # php_phpactor powershell python python_jedi r | ||
| # rego ruby ruby_solargraph rust scala | ||
| # swift terraform toml typescript typescript_vts | ||
| # vue yaml zig | ||
| # (This list may be outdated. For the current list, see values of Language enum here: | ||
| # https://github.com/oraios/serena/blob/main/src/solidlsp/ls_config.py | ||
| # For some languages, there are alternative language servers, e.g. csharp_omnisharp, ruby_solargraph.) | ||
| # Note: | ||
| # - For C, use cpp | ||
| # - For JavaScript, use typescript | ||
| # - For Free Pascal/Lazarus, use pascal | ||
| # Special requirements: | ||
| # Some languages require additional setup/installations. | ||
| # See here for details: https://oraios.github.io/serena/01-about/020_programming-languages.html#language-servers | ||
| # When using multiple languages, the first language server that supports a given file will be used for that file. | ||
| # The first language is the default language and the respective language server will be used as a fallback. | ||
| # Note that when using the JetBrains backend, language servers are not used and this list is correspondingly ignored. | ||
| languages: | ||
| - go | ||
|
|
||
| # the encoding used by text files in the project | ||
| # For a list of possible encodings, see https://docs.python.org/3.11/library/codecs.html#standard-encodings | ||
| encoding: "utf-8" | ||
|
|
||
| # line ending convention to use when writing source files. | ||
| # Possible values: unset (use global setting), "lf", "crlf", or "native" (platform default) | ||
| # This does not affect Serena's own files (e.g. memories and configuration files), which always use native line endings. | ||
| line_ending: | ||
|
|
||
| # The language backend to use for this project. | ||
| # If not set, the global setting from serena_config.yml is used. | ||
| # Valid values: LSP, JetBrains | ||
| # Note: the backend is fixed at startup. If a project with a different backend | ||
| # is activated post-init, an error will be returned. | ||
| language_backend: | ||
|
|
||
| # whether to use project's .gitignore files to ignore files | ||
| ignore_all_files_in_gitignore: true | ||
|
|
||
| # list of additional paths to ignore in this project. | ||
| # Same syntax as gitignore, so you can use * and **. | ||
| # Note: global ignored_paths from serena_config.yml are also applied additively. | ||
| ignored_paths: [] | ||
|
|
||
| # whether the project is in read-only mode | ||
| # If set to true, all editing tools will be disabled and attempts to use them will result in an error | ||
| # Added on 2025-04-18 | ||
| read_only: false | ||
|
|
||
| # list of tool names to exclude. | ||
| # This extends the existing exclusions (e.g. from the global configuration) | ||
| # | ||
| # Below is the complete list of tools for convenience. | ||
| # To make sure you have the latest list of tools, and to view their descriptions, | ||
| # execute `uv run scripts/print_tool_overview.py`. | ||
| # | ||
| # * `activate_project`: Activates a project by name. | ||
| # * `check_onboarding_performed`: Checks whether project onboarding was already performed. | ||
| # * `create_text_file`: Creates/overwrites a file in the project directory. | ||
| # * `delete_lines`: Deletes a range of lines within a file. | ||
| # * `delete_memory`: Deletes a memory from Serena's project-specific memory store. | ||
| # * `execute_shell_command`: Executes a shell command. | ||
| # * `find_referencing_code_snippets`: Finds code snippets in which the symbol at the given location is referenced. | ||
| # * `find_referencing_symbols`: Finds symbols that reference the symbol at the given location (optionally filtered by type). | ||
| # * `find_symbol`: Performs a global (or local) search for symbols with/containing a given name/substring (optionally filtered by type). | ||
| # * `get_current_config`: Prints the current configuration of the agent, including the active and available projects, tools, contexts, and modes. | ||
| # * `get_symbols_overview`: Gets an overview of the top-level symbols defined in a given file. | ||
| # * `initial_instructions`: Gets the initial instructions for the current project. | ||
| # Should only be used in settings where the system prompt cannot be set, | ||
| # e.g. in clients you have no control over, like Claude Desktop. | ||
| # * `insert_after_symbol`: Inserts content after the end of the definition of a given symbol. | ||
| # * `insert_at_line`: Inserts content at a given line in a file. | ||
| # * `insert_before_symbol`: Inserts content before the beginning of the definition of a given symbol. | ||
| # * `list_dir`: Lists files and directories in the given directory (optionally with recursion). | ||
| # * `list_memories`: Lists memories in Serena's project-specific memory store. | ||
| # * `onboarding`: Performs onboarding (identifying the project structure and essential tasks, e.g. for testing or building). | ||
| # * `prepare_for_new_conversation`: Provides instructions for preparing for a new conversation (in order to continue with the necessary context). | ||
| # * `read_file`: Reads a file within the project directory. | ||
| # * `read_memory`: Reads the memory with the given name from Serena's project-specific memory store. | ||
| # * `remove_project`: Removes a project from the Serena configuration. | ||
| # * `replace_lines`: Replaces a range of lines within a file with new content. | ||
| # * `replace_symbol_body`: Replaces the full definition of a symbol. | ||
| # * `restart_language_server`: Restarts the language server, may be necessary when edits not through Serena happen. | ||
| # * `search_for_pattern`: Performs a search for a pattern in the project. | ||
| # * `summarize_changes`: Provides instructions for summarizing the changes made to the codebase. | ||
| # * `switch_modes`: Activates modes by providing a list of their names | ||
| # * `think_about_collected_information`: Thinking tool for pondering the completeness of collected information. | ||
| # * `think_about_task_adherence`: Thinking tool for determining whether the agent is still on track with the current task. | ||
| # * `think_about_whether_you_are_done`: Thinking tool for determining whether the task is truly completed. | ||
| # * `write_memory`: Writes a named memory (for future reference) to Serena's project-specific memory store. | ||
| excluded_tools: [] | ||
|
|
||
| # list of tools to include that would otherwise be disabled (particularly optional tools that are disabled by default). | ||
| # This extends the existing inclusions (e.g. from the global configuration). | ||
| included_optional_tools: [] | ||
|
|
||
| # fixed set of tools to use as the base tool set (if non-empty), replacing Serena's default set of tools. | ||
| # This cannot be combined with non-empty excluded_tools or included_optional_tools. | ||
| fixed_tools: [] | ||
|
|
||
| # list of mode names to that are always to be included in the set of active modes | ||
| # The full set of modes to be activated is base_modes + default_modes. | ||
| # If the setting is undefined, the base_modes from the global configuration (serena_config.yml) apply. | ||
| # Otherwise, this setting overrides the global configuration. | ||
| # Set this to [] to disable base modes for this project. | ||
| # Set this to a list of mode names to always include the respective modes for this project. | ||
| base_modes: | ||
|
|
||
| # list of mode names that are to be activated by default. | ||
| # The full set of modes to be activated is base_modes + default_modes. | ||
| # If the setting is undefined, the default_modes from the global configuration (serena_config.yml) apply. | ||
| # Otherwise, this overrides the setting from the global configuration (serena_config.yml). | ||
| # This setting can, in turn, be overridden by CLI parameters (--mode). | ||
| default_modes: | ||
|
|
||
| # initial prompt for the project. It will always be given to the LLM upon activating the project | ||
| # (contrary to the memories, which are loaded on demand). | ||
| initial_prompt: "" | ||
|
|
||
| # time budget (seconds) per tool call for the retrieval of additional symbol information | ||
| # such as docstrings or parameter information. | ||
| # This overrides the corresponding setting in the global configuration; see the documentation there. | ||
| # If null or missing, use the setting from the global configuration. | ||
| symbol_info_budget: | ||
|
|
||
| # list of regex patterns which, when matched, mark a memory entry as read‑only. | ||
| # Extends the list from the global configuration, merging the two lists. | ||
| read_only_memory_patterns: [] | ||
|
|
||
| # list of regex patterns for memories to completely ignore. | ||
| # Matching memories will not appear in list_memories or activate_project output | ||
| # and cannot be accessed via read_memory or write_memory. | ||
| # To access ignored memory files, use the read_file tool on the raw file path. | ||
| # Extends the list from the global configuration, merging the two lists. | ||
| # Example: ["_archive/.*", "_episodes/.*"] | ||
| ignored_memory_patterns: [] | ||
|
|
||
| # advanced configuration option allowing to configure language server-specific options. | ||
| # Maps the language key to the options. | ||
| # Have a look at the docstring of the constructors of the LS implementations within solidlsp (e.g., for C# or PHP) to see which options are available. | ||
| # No documentation on options means no options are available. | ||
| ls_specific_settings: {} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.