Update gqlgen (and remove packr generate)#1091
Closed
StevenACoffman wants to merge 1 commit intowundergraph:masterfrom
Closed
Update gqlgen (and remove packr generate)#1091StevenACoffman wants to merge 1 commit intowundergraph:masterfrom
StevenACoffman wants to merge 1 commit intowundergraph:masterfrom
Conversation
Signed-off-by: Steve Coffman <steve@khanacademy.org>
Contributor
Author
|
Ok, it looks like this is non-trivial, so I'm going to split this up into some smaller PRs and do this more incrementally, but I'll leave this PR around for a while to remind me of some of the files that are going to need be affected. |
Member
|
thanks for the try also, you could remove this line here to not produce unnecessary changes |
Contributor
Author
|
Sure. Thanks for merging that other PR, btw. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran a script that found every
go.modfile in the repository, updated it to the latest gqlgen (using gomajor which is nice btw), rango mod tidy, and then did ago generate ./...Since this turns out to be non-trivial, I am leaving this PR here to track the work in breaking it up into smaller PRs.
It choked on an oldchore: remove obsolete packr generate directive #1093packrreference that appears unneeded, so I removed that, but otherwise made this draft PR without even running the tests locally just to see where things are at initially.One issue is that in 99designs/gqlgen#3507 there were some changes that where made to support @OneOf and @deprecated on input values
For instance, the codegen config and introspection changed
https://github.com/99designs/gqlgen/pull/3507/files#diff-a15c78971c63172759db98d59084361fa1aec24b37dd739d2680514021975c76R160
Signed-off-by: Steve Coffman steve@khanacademy.org