Skip to content

Add sidebar to fallback frontpage. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hofmannsven wants to merge 13 commits into
base: feature/homepage-fallback
Choose a base branch
from
Open

Add sidebar to fallback frontpage. #43

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ea82db8
disable post revisions
Jun 27, 2018
cce2a82
only check for published pages
Jun 27, 2018
c6c8610
update content
Jun 27, 2018
04105ae
updated database
Jun 27, 2018
70fc566
updated database
Jun 27, 2018
67cdc8f
update lock file
Jun 27, 2018
3e4de21
update content
Jun 28, 2018
62e4482
remove content update from deployment, deploy images
Jul 3, 2018
3701131
only get upcoming meetups
Jul 3, 2018
1cb526a
add meetup api default, fixes 42
Jul 3, 2018
09a358c
Added sidebar to frontpage.
hofmannsven Jul 3, 2018
2eff093
Merge remote-tracking branch 'upstream/master' into homepage-fallback
hofmannsven Jul 3, 2018
16c4b20
Merge remote-tracking branch 'upstream/master' into homepage-fallback
hofmannsven Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/scss/elements/_single.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
justify-content: space-between;
}

.frontpage-fallback-minutes,
.single {
&-main {
flex: 0 0 calc(75% - #{config('spacing', 'medium')});
Expand Down
19 changes: 14 additions & 5 deletions assets/scss/elements/front/_fallback.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
.frontpage-fallback-minutes {
max-width: 100%;
width: 800px;

@include media(config('media', 'breakpoints', 'default') + config('media', 'breakpoints', 'default') * .5) {
transform: translateX(50%);
margin-left: -25%;

&-sidebar {
border: 1px solid #dae1e7;
border-radius: .25rem;
padding: 15px;

@alpipego alpipego Jul 3, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this with a call to config($spacing, 'default') (for 20px padding).

@alpipego alpipego Jul 3, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this with a call to config($spacing, 'default') (for 20px padding).

margin-top: 15px;

h4 {
margin-top: 0;
}

p {
margin-bottom: .5em;
}
}
}
29 changes: 21 additions & 8 deletions web/assets/themes/wp-berlin/front-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,29 @@

while ($minutes->have_posts()) :
?>
<div class="frontpage-fallback-minutes">
<?php
$minutes->the_post();
<div class="main-inner">

@alpipego alpipego Jul 3, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.main-inner is the wrapper for the whole page content, this should not be repeated here.

<div class="frontpage-fallback-minutes-main">

@alpipego alpipego Jul 3, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a wrapper with .frontpage-fallback-minutes

@alpipego alpipego Jul 3, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or replace .main-inner with .frontpage-fallback-minutes

<?php
$minutes->the_post();

$meta = array_map(function (array $values) {
return maybe_unserialize($values[0]);
}, get_post_meta(get_the_ID()));
$meta = array_map(function (array $values) {
return maybe_unserialize($values[0]);
}, get_post_meta(get_the_ID()));

include locate_template(['partials/meeting-minutes/index.php']);
?>
include locate_template(['partials/meeting-minutes/index.php']);
?>
</div>
<aside class="frontpage-fallback-minutes-sidebar">
<h4><?= __('Meeting Minutes', 'wp-berlin'); ?></h4>
<p>
<?=
sprintf(
__('Missed a meetup? Check out our notes, links and code snippets from previous meetups in our other <a href="%s">meeting minutes</a>.', 'wp-berlin'),
'/meeting-minutes'
);
?>
</p>
</aside>
</div>
<?php
endwhile;
Expand Down