Skip to content

Test: prove merge_strings crash on nested-dict .strings (stacked on #741) #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mokagio wants to merge 1 commit into
base: foundation
Choose a base branch
from
Draft

Test: prove merge_strings crash on nested-dict .strings (stacked on #741) #750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions spec/ios_l10n_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,22 @@ def file_encoding(path)
end
end

it 'does not crash merging a text `.strings` file whose value is a nested dictionary' do
# Regression: `merge_strings` bookkeeps keys via `plutil` (which parses a nested-dictionary value
# fine) but re-tokenizes the raw lines through `prefix_keys`, which raises `Invalid character` on
# the `{`. Such a file is still `:text` and passes the format gate, so a public `ios_merge_strings_files`
# run that previously copied the line through now aborts. It should degrade gracefully instead of raising.
content = %("k" = { a = b; };\n)
Dir.mktmpdir('a8c-release-toolkit-l10n-helper-tests-') do |tmp_dir|
input_file = File.join(tmp_dir, 'InfoPlist.strings')
File.write(input_file, content)
output_file = File.join(tmp_dir, 'output.strings')
expect do
described_class.merge_strings(paths: { input_file => 'pfx.' }, output_path: output_file)
end.not_to raise_error
end
end

it 'returns duplicate keys found' do
paths = { fixture('Localizable-utf16.strings') => nil, fixture('non-latin-utf16.strings') => nil }
Dir.mktmpdir('a8c-release-toolkit-l10n-helper-tests-') do |tmp_dir|
Expand Down