Fix Interactivity API setup by DAreRodz · Pull Request #8593 · woocommerce/woocommerce-blocks

DAreRodz · 2023-03-01T11:52:59Z

What

Fixes how the Interactivity API files are loaded, which now requires two conditions to be true:

The filter woocommerce_blocks_enable_interactivity_api should be explicitly set to true
The WP_HTML_Tag_Processor class, either included by WP core or the Gutenberg plugin, should be defined.

Why

All e2e tests were recently failing due to a 500 response error from the server.

It was a bug introduced in #8447, that was causing the Interactivity API files to be unnecessarily loaded, and also requiring missing files from the Gutenberg plugin.

How

Only requiring /src/Interactivity/woo-directives.php when those two conditions are true.

Do not include in the Testing Notes

github-actions · 2023-03-01T11:55:45Z

The release ZIP for this PR is accessible via:

https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-8593.zip

Script Dependencies Report

The compare-assets action has detected some changed script dependencies between this branch and trunk. Please review and confirm the following are correct before merging.

Script Handle	Added
`wc-blocks.js`	`wp-blocks`, `wp-compose`, `wp-element`, `wp-hooks`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`active-filters.js`	`lodash`, `react`, `wc-blocks-data-store`, `wc-price-format`, `wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`all-products.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-blocks-shared-context`, `wc-blocks-shared-hocs`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-escape-html`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`all-reviews.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`	⚠️
`attribute-filter.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-settings`, `wp-a11y`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`	⚠️
`breadcrumbs.js`	`wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`cart.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-blocks-shared-context`, `wc-blocks-shared-hocs`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-core-data`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-editor`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-plugins`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`catalog-sorting.js`	`wp-block-editor`, `wp-blocks`, `wp-components`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`checkout.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-core-data`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-editor`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-plugins`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`customer-account.js`	`wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`featured-category.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`featured-product.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`filter-wrapper.js`	`wp-block-editor`, `wp-blocks`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`handpicked-products.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`legacy-template.js`	`wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-data`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`mini-cart.js`	`react`, `wc-price-format`, `wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-dom`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`mini-cart-contents.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`store-notices.js`	`wp-block-editor`, `wp-blocks`, `wp-components`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`price-filter.js`	`lodash`, `react`, `wc-blocks-data-store`, `wc-price-format`, `wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-element`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`product-best-sellers.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`product-category.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`product-categories.js`	`wp-block-editor`, `wp-blocks`, `wp-components`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`	⚠️
`product-new.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`product-on-sale.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`product-query.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-data`, `wp-element`, `wp-hooks`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`product-results-count.js`	`wp-block-editor`, `wp-blocks`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`product-search.js`	`wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`product-tag.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`product-top-rated.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`products-by-attribute.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`rating-filter.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-settings`, `wp-a11y`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`	⚠️
`reviews-by-category.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`reviews-by-product.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`single-product.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-blocks-shared-context`, `wc-blocks-shared-hocs`, `wc-price-format`, `wc-settings`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-escape-html`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`stock-filter.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-settings`, `wp-a11y`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`	⚠️

This comment was automatically generated by the ./github/compare-assets action.

TypeScript Errors Report

Files with errors: 486
Total errors: 2334

🎉 🎉 This PR does not introduce new TS errors.

_{comments-aggregator}

github-actions · 2023-03-01T12:02:14Z

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged

Filename	Size
`build/active-filters-frontend.js`	7.98 kB
`build/active-filters-wrapper-frontend.js`	5.99 kB
`build/active-filters.js`	7.33 kB
`build/all-products-frontend.js`	11.7 kB
`build/all-products.js`	36.4 kB
`build/all-reviews.js`	7.67 kB
`build/attribute-filter-frontend.js`	22.4 kB
`build/attribute-filter-wrapper-frontend.js`	7.08 kB
`build/attribute-filter.js`	12.4 kB
`build/blocks-checkout.js`	41.2 kB
`build/breadcrumbs.js`	2.04 kB
`build/cart-blocks/cart-accepted-payment-methods-frontend.js`	1.38 kB
`build/cart-blocks/cart-cross-sells-frontend.js`	253 B
`build/cart-blocks/cart-cross-sells-products-frontend.js`	9.71 kB
`build/cart-blocks/cart-express-payment--checkout-blocks/express-payment-frontend.js`	5.19 kB
`build/cart-blocks/cart-express-payment-frontend.js`	720 B
`build/cart-blocks/cart-items-frontend.js`	299 B
`build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js`	5.35 kB
`build/cart-blocks/cart-line-items-frontend.js`	1.06 kB
`build/cart-blocks/cart-order-summary-frontend.js`	1.24 kB
`build/cart-blocks/cart-totals-frontend.js`	322 B
`build/cart-blocks/empty-cart-frontend.js`	345 B
`build/cart-blocks/filled-cart-frontend.js`	655 B
`build/cart-blocks/order-summary-coupon-form-frontend.js`	1.62 kB
`build/cart-blocks/order-summary-discount-frontend.js`	2.12 kB
`build/cart-blocks/order-summary-fee-frontend.js`	274 B
`build/cart-blocks/order-summary-heading-frontend.js`	455 B
`build/cart-blocks/order-summary-shipping-frontend.js`	14.8 kB
`build/cart-blocks/order-summary-subtotal-frontend.js`	275 B
`build/cart-blocks/order-summary-taxes-frontend.js`	434 B
`build/cart-blocks/proceed-to-checkout-frontend.js`	1.24 kB
`build/cart-frontend.js`	28.9 kB
`build/cart.js`	47.5 kB
`build/catalog-sorting.js`	1.7 kB
`build/checkout-blocks/actions-frontend.js`	1.85 kB
`build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js`	3.92 kB
`build/checkout-blocks/billing-address-frontend.js`	1.18 kB
`build/checkout-blocks/contact-information-frontend.js`	2.05 kB
`build/checkout-blocks/express-payment-frontend.js`	1.13 kB
`build/checkout-blocks/fields-frontend.js`	345 B
`build/checkout-blocks/order-note-frontend.js`	1.14 kB
`build/checkout-blocks/order-summary-cart-items-frontend.js`	3.67 kB
`build/checkout-blocks/order-summary-coupon-form-frontend.js`	1.79 kB
`build/checkout-blocks/order-summary-discount-frontend.js`	2.29 kB
`build/checkout-blocks/order-summary-fee-frontend.js`	276 B
`build/checkout-blocks/order-summary-frontend.js`	1.24 kB
`build/checkout-blocks/order-summary-shipping-frontend.js`	14.9 kB
`build/checkout-blocks/order-summary-subtotal-frontend.js`	275 B
`build/checkout-blocks/order-summary-taxes-frontend.js`	435 B
`build/checkout-blocks/payment-frontend.js`	8.43 kB
`build/checkout-blocks/pickup-options-frontend.js`	2.8 kB
`build/checkout-blocks/shipping-address-frontend.js`	1.14 kB
`build/checkout-blocks/shipping-method-frontend.js`	2.28 kB
`build/checkout-blocks/shipping-methods-frontend.js`	4.58 kB
`build/checkout-blocks/terms-frontend.js`	1.56 kB
`build/checkout-blocks/totals-frontend.js`	324 B
`build/checkout-frontend.js`	30.5 kB
`build/checkout.js`	44.2 kB
`build/customer-account.js`	3.08 kB
`build/featured-category.js`	13.5 kB
`build/featured-product.js`	13.7 kB
`build/filter-wrapper-frontend.js`	14.1 kB
`build/filter-wrapper.js`	2.39 kB
`build/general-style-rtl.css`	1.31 kB
`build/general-style.css`	1.31 kB
`build/handpicked-products.js`	7.24 kB
`build/legacy-template.js`	5.29 kB
`build/mini-cart-component-frontend.js`	28 kB
`build/mini-cart-contents-block/empty-cart-frontend.js`	366 B
`build/mini-cart-contents-block/filled-cart-frontend.js`	268 B
`build/mini-cart-contents-block/footer-frontend.js`	2.86 kB
`build/mini-cart-contents-block/items-frontend.js`	237 B
`build/mini-cart-contents-block/products-table-frontend.js`	589 B
`build/mini-cart-contents-block/shopping-button-frontend.js`	313 B
`build/mini-cart-contents-block/title-frontend.js`	367 B
`build/mini-cart-contents.js`	16.6 kB
`build/mini-cart-frontend.js`	2 kB
`build/mini-cart.js`	4.3 kB
`build/price-filter-frontend.js`	13.8 kB
`build/price-filter-wrapper-frontend.js`	6.99 kB
`build/price-filter.js`	8.39 kB
`build/price-format.js`	1.19 kB
`build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js`	253 B
`build/product-add-to-cart--product-button--product-image--product-rating--product-title.js`	151 B
`build/product-add-to-cart-frontend.js`	6.71 kB
`build/product-add-to-cart.js`	8.61 kB
`build/product-best-sellers.js`	7.59 kB
`build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js`	500 B
`build/product-button--product-image--product-price--product-rating--product-sale-badge--product-title.js`	262 B
`build/product-button-frontend.js`	2.22 kB
`build/product-button.js`	3.99 kB
`build/product-categories.js`	2.36 kB
`build/product-category-list-frontend.js`	1.19 kB
`build/product-category-list.js`	502 B
`build/product-category.js`	8.58 kB
`build/product-image-frontend.js`	2.23 kB
`build/product-image.js`	4.09 kB
`build/product-new.js`	7.58 kB
`build/product-on-sale.js`	7.91 kB
`build/product-price-frontend.js`	2.32 kB
`build/product-price.js`	1.58 kB
`build/product-query.js`	6.6 kB
`build/product-rating-frontend.js`	1.65 kB
`build/product-rating.js`	920 B
`build/product-results-count.js`	1.65 kB
`build/product-sale-badge-frontend.js`	1.45 kB
`build/product-sale-badge.js`	816 B
`build/product-search.js`	2.63 kB
`build/product-sku-frontend.js`	629 B
`build/product-sku.js`	378 B
`build/product-stock-indicator-frontend.js`	1.31 kB
`build/product-stock-indicator.js`	645 B
`build/product-summary-frontend.js`	1.58 kB
`build/product-summary.js`	920 B
`build/product-tag-list-frontend.js`	1.18 kB
`build/product-tag-list.js`	497 B
`build/product-tag.js`	8.07 kB
`build/product-title-frontend.js`	1.65 kB
`build/product-title.js`	3.46 kB
`build/product-top-rated.js`	7.82 kB
`build/products-by-attribute.js`	8.52 kB
`build/rating-filter-frontend.js`	20.9 kB
`build/rating-filter-wrapper-frontend.js`	5.61 kB
`build/rating-filter.js`	7.41 kB
`build/reviews-by-category.js`	11.2 kB
`build/reviews-by-product.js`	12.3 kB
`build/reviews-frontend.js`	7.14 kB
`build/single-product-frontend.js`	17.9 kB
`build/single-product.js`	9.94 kB
`build/stock-filter-frontend.js`	21.1 kB
`build/stock-filter-wrapper-frontend.js`	5.85 kB
`build/stock-filter.js`	8.14 kB
`build/store-notices.js`	1.69 kB
`build/vendors--attribute-filter-wrapper--cart-blocks/cart-cross-sells-products--cart-blocks/order-summary--82e4ed06-frontend.js`	6.86 kB
`build/vendors--attribute-filter-wrapper--rating-filter-wrapper--stock-filter-wrapper-frontend.js`	7.69 kB
`build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/cart-line-items--cart-blocks/cart-order--3c5fe802-frontend.js`	5.26 kB
`build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/order-summary-shipping--checkout-blocks--18f9376a-frontend.js`	19.4 kB
`build/vendors--cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js`	7.25 kB
`build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js`	3.14 kB
`build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--5b8feb0b-frontend.js`	4.83 kB
`build/vendors--checkout-blocks/shipping-method-frontend.js`	12 kB
`build/vendors--checkout-blocks/shipping-methods-frontend.js`	8.84 kB
`build/wc-blocks-data.js`	21.5 kB
`build/wc-blocks-editor-style-rtl.css`	5.74 kB
`build/wc-blocks-editor-style.css`	5.75 kB
`build/wc-blocks-google-analytics.js`	1.56 kB
`build/wc-blocks-middleware.js`	933 B
`build/wc-blocks-registry.js`	3.15 kB
`build/wc-blocks-shared-context.js`	1.52 kB
`build/wc-blocks-shared-hocs.js`	1.73 kB
`build/wc-blocks-style-rtl.css`	26.7 kB
`build/wc-blocks-style.css`	26.7 kB
`build/wc-blocks-vendors-style-rtl.css`	1.96 kB
`build/wc-blocks-vendors-style.css`	1.96 kB
`build/wc-blocks-vendors.js`	64.4 kB
`build/wc-blocks.js`	2.63 kB
`build/wc-payment-method-bacs.js`	816 B
`build/wc-payment-method-cheque.js`	811 B
`build/wc-payment-method-cod.js`	909 B
`build/wc-payment-method-paypal.js`	837 B
`build/wc-settings.js`	2.6 kB
`build/wc-shipping-method-pickup-location.js`	29.7 kB
`build/woo-directives-runtime.js`	2.73 kB
`build/woo-directives-vendors.js`	7.91 kB

_{compressed-size-action}

DAreRodz · 2023-03-01T12:10:10Z

I see there are still e2e tests failing. No more "500 (Internal Server Error)", though.

Aljullu

@DAreRodz what do you think about not including this PR in the changelog? If you agree, could you add the skip-changelog label?

Besides that, I left one question below which I think needs to be addressed.

I see there are still e2e tests failing. No more "500 (Internal Server Error)", though.

Right, they feel unrelated. We still have some tests in trunk that we need to fix.

Aljullu · 2023-03-01T12:40:39Z

+ * @param bool $enabled True if the Interactivity API is manually enabled.
+ * @return bool True if _also_ the Gutenberg plugin is enabled.
+ */
+function woocommerce_blocks_is_gutenberg_enabled( $enabled ) {


Heads-up that WC core has a policy of L-2 support for WP, so we won't be able to remove this even when WP 6.2 is released.

I wonder whether it would be better to check the WP and GB versions directly instead of simply checking if GB is enabled. What do you think?

I also wonder if we could make this function generic so it's not coupled to the Interactivity API. That might be useful for other blocks. For example, we have at least one other block that checks if GB is enabled, so we could try to make this util function usable in that case as well? (That last comment is not a blocker, just me thinking out loud)

Heads-up that WC core has a policy of L-2 support for WP, so we won't be able to remove this even when WP 6.2 is released.

Oh, thanks for the heads-up. I guess the L-2 support means that this plugin will have to support the two previously released versions of WP as well, so this is not a temporary fix, right? 👍

I wonder whether it would be better to check the WP and GB versions directly instead of simply checking if GB is enabled. What do you think?

Good idea, although not sure how to best implement that. I saw a PHP function called version_compare. Do you know if there is a more reliable way to compare versions in WordPress, or is it OK to use that?

Oh, thanks for the heads-up. I guess the L-2 support means that this plugin will have to support the two previously released versions of WP as well, so this is not a temporary fix, right? 👍

Yes, exactly. WC currently supports WP 5.9, 6.0 and 6.1. So it won't be until WP 6.4 is released that we will be able to remove support for WP 6.1.

Sidenote: the truth is that "officially" WC Blocks has an L-0 support policy but WC core has an L-2 support policy. Given that WC Blocks ends up being merged into WC core, in practice we have to operate as if WC Blocks also had an L-2 support policy. I know it's a bit confusing. 😅

Good idea, although not sure how to best implement that. I saw a PHP function called version_compare. Do you know if there is a more reliable way to compare versions in WordPress, or is it OK to use that?

We use version_compare in several places in the codebase, so I think it's fine to use it.

The Gutenberg plugin kind of tries to remove the complexity of version checks etc by simply checking if the WP_HTML_Tag_Processor class exists, and by loading it from its own compatibility layer otherwise.

Is that something we can imitate here? Something like

function woocommerce_blocks_has_wp_html_tag_processor( $enabled ) { if ( ! function_exists( 'is_plugin_active' ) ) { include_once ABSPATH . 'wp-admin/includes/plugin.php'; } return $enabled && class_exists( 'WP_HTML_Tag_Processor' ); } add_filter( 'woocommerce_blocks_enable_interactivity_api', 'woocommerce_blocks_has_wp_html_tag_processor', 999 );

We'd need to make sure that the woocommerce_blocks_enable_interactivity_api filter runs after the GB plugin is activated (if present), but that seems feasible 🤔

Seems kinda preferable to me over having a version check and manual imports from GB's compat layer...

We'd need to make sure that the woocommerce_blocks_enable_interactivity_api filter runs after the GB plugin is activated (if present), but that seems feasible 🤔

@ockham I'm applying that filter in the plugins_loaded hook. I guess that runs after GB plugin is activated?

https://github.com/woocommerce/woocommerce-blocks/blob/25af68b1406e872bafa8221797a61c24c9eec4f2/woocommerce-gutenberg-products-block.php#L323-L324

I'm applying that filter in the plugins_loaded hook. I guess that runs after GB plugin is activated?

From what I understand, yeah: Gutenberg's code should be loaded by the time plugins_loaded is triggered.

(To be sure, you can probably try with WP 6.1; disable the plugin and verify that the interactivity code isn't loaded, then re-enable the plugin and verify that the interactivity code is loaded.)

DAreRodz · 2023-03-01T18:35:59Z

@Aljullu, @ockham, thanks a lot for your feedback. The PR is ready for review again.

Aljullu

Testing directly for WP_HTML_Tag_Processor existence instead of my suggestion is much better. Thanks @DAreRodz and @ockham! 👏

LGTM

DAreRodz added 2 commits March 1, 2023 12:39

Only load Interactivity API if enabled

25af68b

Use requires again inside wp-html

68b8bed

DAreRodz requested review from Aljullu and albarin March 1, 2023 11:52

Aljullu reviewed Mar 1, 2023

View reviewed changes

DAreRodz added the skip-changelog PRs that you don't want to appear in the changelog. label Mar 1, 2023

DAreRodz added 2 commits March 1, 2023 19:11

Check if class exist instead of plugin

650e065

Remove wp-html.php file

de6c42d

DAreRodz requested review from Aljullu and ockham March 1, 2023 18:32

Merge branch 'trunk' into fix/interactivity-api-setup

216dfcf

Merge branch 'trunk' into fix/interactivity-api-setup

0ee100e

Aljullu approved these changes Mar 2, 2023

View reviewed changes

github-actions Bot added this to the 9.8.0 milestone Mar 2, 2023

github-actions Bot added the status: ready to merge label Mar 2, 2023

Merge branch 'trunk' into fix/interactivity-api-setup

bafabc1

DAreRodz merged commit a36425d into trunk Mar 2, 2023

DAreRodz deleted the fix/interactivity-api-setup branch March 2, 2023 12:46

github-actions Bot removed the status: ready to merge label Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Interactivity API setup#8593

Fix Interactivity API setup#8593
DAreRodz merged 7 commits into
trunkfrom
fix/interactivity-api-setup

DAreRodz commented Mar 1, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 1, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 1, 2023 •

edited

Loading

Uh oh!

DAreRodz commented Mar 1, 2023

Uh oh!

Aljullu left a comment

Uh oh!

Aljullu Mar 1, 2023

Uh oh!

DAreRodz Mar 1, 2023

Uh oh!

Aljullu Mar 1, 2023

Uh oh!

ockham Mar 1, 2023

Uh oh!

DAreRodz Mar 1, 2023

Uh oh!

ockham Mar 1, 2023

Uh oh!

DAreRodz commented Mar 1, 2023

Uh oh!

Aljullu left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

DAreRodz commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

How

Uh oh!

github-actions Bot commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Script Dependencies Report

TypeScript Errors Report

Uh oh!

github-actions Bot commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DAreRodz commented Mar 1, 2023

Uh oh!

Aljullu left a comment

Choose a reason for hiding this comment

Uh oh!

Aljullu Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

DAreRodz Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

Aljullu Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

ockham Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

DAreRodz Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

ockham Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

DAreRodz commented Mar 1, 2023

Uh oh!

Aljullu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DAreRodz commented Mar 1, 2023 •

edited

Loading

github-actions Bot commented Mar 1, 2023 •

edited

Loading

github-actions Bot commented Mar 1, 2023 •

edited

Loading