This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Update directives prefix to data-woo-#8316
Merged
Merged
Conversation
Contributor
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
Detailsassets/js/interactivity/directives.js |
6 tasks
Contributor
|
Size Change: +140 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
DAreRodz
changed the title
woo- and wpx to wooStoredata-woo- and wpx to wooStore
Contributor
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
Bot
added
the
status: stale
DAreRodz
removed
the
status: stale
DAreRodz
changed the title
data-woo- and wpx to wooStoredata-woo-
luisherranz
approved these changes
Feb 15, 2023
luisherranz
left a comment
luisherranz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I also left a minor comment.
| @@ -0,0 +1,3 @@ | |||
| export const cstMetaTagItemprop = 'woo-client-side-transitions'; | |||
Collaborator
There was a problem hiding this comment.
I'm not sure if we will remove it later once we switch to Product block-only navigation, but to match the upstream this should now be called woo-client-side-navigation.
Collaborator
Author
There was a problem hiding this comment.
OK, I think I've already included those changes in #8447, so I'm going to merge this PR and continue the development there.
dinhtungdu
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename existing
wpprefixes todata-woo.Tracking issue: woocommerce/woocommerce#42486
Why
It is better if we don't use
wpfor now, as this is going to be something woo-specific until the final Interactivity API is released.How
Basically, updating the interactivity library to match WordPress/block-interactivity-experiments#142 and changing the value of the properties defined in
constants.js.