Repository navigation
Conversation
…fault MIME allowlist The 300s default agentResponseTimeoutMs kills legitimate long-running agent turns before they finish -- observed 7 of 13 recent failed inbound tasks dying at exactly ~300000ms in production, well within what the underlying agent harness allows per turn. Raised to 1200000ms (20 min). The default MIME allowlist has no text/markdown (or a text/* wildcard like the existing image/*, audio/*, video/* entries), so any peer sending a .md attachment -- a common thing to hand between agents -- gets rejected outright in ~9ms. Added text/markdown to the default. Both are one-line default-value changes with no architecture impact. Full test suite passes (513/513).
Author
|
Separate from the PR itself — wanted to say this plugin has been genuinely great to work with. We're running it across a 3-host agent fleet for A2A coordination and it's held up well as real infrastructure, not just a demo. Appreciate the work that's gone into it. Starred the repo too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small default-value fixes, hit running a multi-host A2A fleet (3 peers) in production.
1.
timeouts.agentResponseTimeoutMsdefaulted to 300,000ms (5 min)In our audit log (
a2a-audit.jsonl), 7 of 13 recent failed inbound tasks died at ~300000–300200ms — the gateway killing tasks that were still legitimately in progress on the agent side (the underlying harness we're bridging to allows up to 7200s/turn). This is indistinguishable in the audit log from a genuine agent-side failure without cross-referencing the agent's own logs. Raised the default to 1,200,000ms (20 min).2. Default
allowedMimeTypeshas notext/markdown(or atext/*wildcard)Default list (from #16):
image/*, application/pdf, text/plain, text/csv, application/json, audio/*, video/*. A peer sending a.mdfile attachment — a common thing to hand between agents (debug notes, docs) — gets rejected outright:File validation failed: MIME type rejected: "text/markdown", task fails in ~9ms. Addedtext/markdownto the default.Testing
Full suite passes: 513/513, 0 failures. Neither change is covered by an existing test assertion on the exact default value (checked before changing), so nothing needed updating.
Note
Both remain fully overridable via
timeouts.agentResponseTimeoutMs/security.allowedMimeTypesinopenclaw.plugin.jsonas before — this only changes what happens when those aren't set.Also — genuinely enjoying using this plugin across our fleet, it's been solid infrastructure for agent-to-agent coordination. Thanks for building and maintaining it.