port(wasm): Add support for --export-if-defined - #2408
Merged
Conversation
lapla-cogito
changed the title
--export-if-defined--export-if-defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for wasm-ld's
--export-if-definedoption.Symbols passed through
--export-if-definedare exported when defined and ignored otherwise. Existing--exportbehaviour remains unchanged and still reports missing symbols as errors.Tested locally on NixOS with:
nix develop --command env RUSTFLAGS=-Dwarnings cargo test --profile ci --workspacenix develop --command env NIX_HARDENING_ENABLE= RUSTFLAGS=-Dwarnings cargo test --features wasm -- wasmcargo clippy --all-targets --workspace --target x86_64-unknown-linux-gnucargo clippy --all-targets --workspace --target x86_64-unknown-linux-gnu --no-default-featurescargo +nightly fmt --all -- --checkRelated to #2335.