Fixing setup of resource name when loading i18n resources#1467
Merged
Conversation
Checking whether a resource file exists does not work with Webjars as previously implemented. The new check is now a simple implementation whether the given language string is empty or not. Issue # wicketstuff#1465
solomax
approved these changes
May 30, 2026
solomax
pushed a commit
that referenced
this pull request
May 30, 2026
* fix: fixing of loading of i18n resources Issue #1465 * fix: fixing setup of resource name when loading i18n resources Checking whether a resource file exists does not work with Webjars as previously implemented. The new check is now a simple implementation whether the given language string is empty or not. Issue # #1465 --------- Co-authored-by: Timo Schmidt <timo@xinterchange.net>
Contributor
|
Thanks a lot for the fix @xomit ! :) |
Contributor
Author
|
@solomax Thank you for the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking whether a resource file exists does not work with Webjars
as previously implemented. The new check is now a simple implementation
whether the given language string is empty or not.