Merged
Conversation
annevk
approved these changes
Aug 2, 2018
notifications.bs
Outdated
| <a for=notification>service worker registration</a> and <var>callback</var>. | ||
| </ol> | ||
| <li><p>If <var>notification</var> is a <a>persistent notification</a> and <var>notification</var> | ||
| was closed by the user, then <a>Fire a service worker notification event</a> named |
Contributor
Author
|
Nit addressed. Happy to help with #132 if merging is hard. Ping me when it comes to that time. |
annevk
approved these changes
Aug 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've simplified event firing as part of w3c/ServiceWorker#1199.
Don't merge this until w3c/ServiceWorker#1199 merges, but you can review now.
Preview | Diff