Skip to content

[import-bytes] add bytes sec-fetch-dest and accept #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
styfle wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[import-bytes] add bytes sec-fetch-dest and accept #1912

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d872746
[import-bytes] add "bytes" sec-fetch-dest and accept
styfle Mar 5, 2026
3b78a7b
fix: apply suggestions from review
styfle Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions fetch.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1819,6 +1819,7 @@ device to assist defining CSP and Mixed Content. It is not exposed to JavaScript
the empty string,
"<code>audio</code>",
"<code>audioworklet</code>",
"<code>bytes</code>",
"<code>document</code>",
"<code>embed</code>",
"<code>font</code>",
Expand Down Expand Up @@ -1874,7 +1875,7 @@ not always relevant and might require different behavior.
<th>CSP directive
<th>Features
<tr>
<td rowspan=21>""
<td rowspan=22>""
<td>"<code>report</code>"
<td rowspan=2>&mdash;
<td>CSP, NEL reports.
Expand Down Expand Up @@ -1950,6 +1951,10 @@ not always relevant and might require different behavior.
<td>"<code>json</code>"
<td><code>connect-src</code>
<td><code>import "..." with { type: "json" }</code>
<tr>
<td>"<code>bytes</code>"
<td><code>connect-src</code>
<td><code>import "..." with { type: "bytes" }</code>
<tr>
<td>"<code>style</code>"
<td><code>style-src</code>
Expand Down Expand Up @@ -2303,6 +2308,7 @@ bookkeeping details by the <a for=/>fetch</a> algorithm.

<p>A <dfn export>subresource request</dfn> is a <a for=/>request</a>
whose <a for=request>destination</a> is "<code>audio</code>", "<code>audioworklet</code>",
"<code>bytes</code>",
"<code>font</code>", "<code>image</code>", "<code>json</code>", "<code>manifest</code>",
"<code>paintworklet</code>", "<code>script</code>", "<code>style</code>", "<code>track</code>",
"<code>video</code>", "<code>xslt</code>", or the empty string.
Copy link
Copy Markdown
Member

@annevk annevk Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rewrap here.

Copy link
Copy Markdown
Contributor Author

@styfle styfle Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I adjusted the line wrap 👍

Expand Down Expand Up @@ -3079,10 +3085,10 @@ optional <a for=/>WebTransport-hash list</a>
given <var>key</var>, <var>url</var>'s <a for=url>origin</a>, <var>credentials</var>,
<var>proxy</var>, an <a>implementation-defined</a> <a for=/>host</a> from <var>hosts</var>,
<var>timingInfo</var>, <var>requireUnreliable</var>, and <var>webTransportHashes</var> an
<a>implementation-defined</a> number of times, <a>in parallel</a> from each other, and wait for
at least 1 to return a value. In an <a>implementation-defined</a> manner, select a value to
return from the returned values and return it. Any other returned values that are
<a>connections</a> may be closed.
<a>implementation-defined</a> number of times, <a>in parallel</a> from each other, and wait for
at least 1 to return a value. In an <a>implementation-defined</a> manner, select a value to
return from the returned values and return it. Any other returned values that are
<a>connections</a> may be closed.
Copy link
Copy Markdown
Member

@annevk annevk Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation got lost here?

Copy link
Copy Markdown
Contributor Author

@styfle styfle Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed 👍


<p class=note>Essentially this allows an implementation to pick one or more
<a for=/>IP addresses</a> from the return value of <a>resolve an origin</a> (assuming
Expand Down Expand Up @@ -4684,6 +4690,9 @@ the response. [[!HTTP-CACHING]]
<dt>"<code>json</code>"
<dd>`<code>application/json,*/*;q=0.5</code>`

<dt>"<code>bytes</code>"
<dd>`<code>*/*</code>`
Copy link
Copy Markdown
Member

@annevk annevk Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this first so they are in lexicographical order.

Copy link
Copy Markdown
Contributor Author

@styfle styfle Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice I missed that. Fixed 👍


<dt>"<code>style</code>"
<dd>`<code>text/css,*/*;q=0.1</code>`
</dl>
Expand Down Expand Up @@ -8414,7 +8423,7 @@ dictionary RequestInit {
any window; // can only be set to null
};

enum RequestDestination { "", "audio", "audioworklet", "document", "embed", "font", "frame", "iframe", "image", "json", "manifest", "object", "paintworklet", "report", "script", "sharedworker", "style", "track", "video", "worker", "xslt" };
enum RequestDestination { "", "audio", "audioworklet", "bytes", "document", "embed", "font", "frame", "iframe", "image", "json", "manifest", "object", "paintworklet", "report", "script", "sharedworker", "style", "track", "video", "worker", "xslt" };
enum RequestMode { "navigate", "same-origin", "no-cors", "cors" };
enum RequestCredentials { "omit", "same-origin", "include" };
enum RequestCache { "default", "no-store", "reload", "no-cache", "force-cache", "only-if-cached" };
Expand Down