-
Notifications
You must be signed in to change notification settings - Fork 331
Add OpaqueRange interface #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stephanieyzhang
wants to merge
16
commits into
whatwg:main
Choose a base branch
from
stephanieyzhang:fcr-initial
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−5
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e19d60b
initial changes
stephanieyzhang d7b3bee
update to match format of other ranges
stephanieyzhang 05b6b0a
address dan's comments
stephanieyzhang e5b3361
formatting
stephanieyzhang 55b34b7
pt 2 of Dan's comments
stephanieyzhang 9858599
remove commit-sha
stephanieyzhang f65c447
fixes for dan's comments
stephanieyzhang a6c4f52
add geometry methods
stephanieyzhang c947ca1
rename to PlainTextRange + tpac changes
stephanieyzhang 3d5050a
Merge branch 'whatwg:main' into fcr-initial
stephanieyzhang 96e153b
add OpaqueRange + allow null AbstractRange containers
stephanieyzhang da26d0a
Merge branch 'fcr-initial' of https://github.com/stephanieyzhang/dom …
stephanieyzhang cf4259e
remove explicit 'opaque range string'
stephanieyzhang b3108ac
cleanup redundancies between abstractrange and opaquerange
stephanieyzhang b95b1b6
add disconnect
stephanieyzhang 8ea58fc
add mutationobserver to fix disconnect build break
stephanieyzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why OpaqueRange offsets are readonly? Or there isn't any method to update them?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The offsets are readonly since they're inherited from AbstractRange. Currently the HTML PR defines
createValueRange(start, end)on the element for creation. We haven't yet added an API for updating, so that's an open question. Some options could be an element-side API (e.g.updateValueRange(range, start, end))to keep OpaqueRange generic, or setters directly on OpaqueRange.Would appreciate your thoughts @annevk @smaug----