fix: presets imports - #48
Merged
Merged
Conversation
stripExtension now returns null for .d.ts files so declaration files like copy-ddb.d.ts don't appear as duplicate preset entries in the wizard menu. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…filename listAvailablePresetsWithDescriptions now dynamically imports all preset files in parallel and reads name + description from the module export. Broken or nameless files are silently skipped. Deduplication uses the module's name field. listAvailablePresets (used by PresetLoader) stays filename-based for the resolution path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Helps debug typos and broken exports in user preset files instead of silently skipping them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.d.tsfiles in preset discovery — declaration files likecopy-ddb.d.tswere listed as duplicate entries (copy-ddb.d) in the wizard menu. BothpresetDiscovery.tsandPresetLoader.tsnow filter them out.listAvailablePresetsWithDescriptionsnow dynamically imports all preset files in parallel and readsname/descriptionfromexport default. Broken or nameless files are skipped instead of shown with empty descriptions.Test plan
yarn transferwizard shows clean preset list (no.dduplicates)namedifferent from filename show the module nameyarn full— all tests pass🤖 Generated with Claude Code