tooling(meetings): migrate meetings e2e tests to playwright#704
tooling(meetings): migrate meetings e2e tests to playwright#704riteshfyi wants to merge 4 commits into
Conversation
The previous merge commit included generated docs/ sample build output (bundles and SVG assets). Remove them from version control; they remain on disk and are regenerated by `yarn samples:build`.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
💡 Codex ReviewIn the widget source, focus management looks for Lines 94 to 96 in 32ae068 When ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This changelog source file was inadvertently removed in the docs build artifact cleanup. It is a real source file and belongs in version control.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fb20e33f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const projects = testScope === 'cc' ? ccProjects | ||
| : testScope === 'meetings' ? meetingsProjects | ||
| : [...ccProjects, ...meetingsProjects]; |
There was a problem hiding this comment.
Scope unqualified e2e runs to one setup
When yarn run test:e2e is used (the cc widgets workflow still does this in .github/workflows/pull-request.yml), this default branch schedules both the CC OAuth setup and the new meetings setup together. Both setup files read/modify/write the same root .env without any dependency between them, so under the existing parallel Playwright run the last writer can drop the other setup's generated tokens and leave either CC or meeting tests without credentials; use the scoped script in the workflow or serialize/merge the setup writes.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this is addressed in the workflow update pr
| this.unmuteAudioBtn = this.controls.getByRole('button', { name: 'Unmute' }); | ||
| this.muteVideoBtn = this.controls.getByRole('button', { name: 'Stop video' }); | ||
| this.unmuteVideoBtn = this.controls.getByRole('button', { name: 'Start video' }); | ||
| this.joinMeetingBtn = this.controls.getByRole('button', { name: /^(Muted, video off|Unmuted, video on)$/ }); |
There was a problem hiding this comment.
Target the actual Join meeting button
When the migrated suite reaches the join step, this locator only matches buttons named with the muted/unmuted state, but the widget's pre-join control is still exposed and queried as aria-label="Join meeting" in packages/@webex/widgets/src/widgets/WebexMeetings/WebexMeetings.jsx, and the removed WDIO page clicked the visible Join meeting control. In that state Playwright will not find/click the join button, so the tests time out before verifying the in-meeting UI.
Useful? React with 👍 / 👎.
COMPLETES #NA
This pull request addresses
< DESCRIBE THE CONTEXT OF THE ISSUE >
We had our meetings widget e2e tests moved from wdio to playwright.
by making the following changes
1.remove wdio dependencies
2. added playwright config , dependenices
3. moved tests from wdio to playwright.
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.