script: Fix panic when deleting after range.deleteContents#59670
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom May 5, 2026
Merged
script: Fix panic when deleting after range.deleteContents#59670servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
Conversation
The state of the document after `range.deleteContents` leads to the delete command to traverse to the root element and then crash. Instead, we should simply stop the loop and continue the algorithm and delete backwards. Fixes web-platform-tests#44742 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
wpt-pr-bot
approved these changes
May 5, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state of the document after
range.deleteContentsleads to the delete command to traverse to the root element and then crash. Instead, we should simply stop the loop and continue the algorithm and delete backwards.Also added an additional test I created when trying to figure out what other browsers are doing
and added spec comments to
deleteContents. Lastly, also incorporate the spec fix of whatwg/dom#1452Fixes #44742
Testing: WPT
Reviewed in servo/servo#44748