script: Remove check for zero request body length in FetchLater#58726
Merged
annevk merged 1 commit intoweb-platform-tests:masterfrom Apr 26, 2026
Merged
script: Remove check for zero request body length in FetchLater#58726annevk merged 1 commit intoweb-platform-tests:masterfrom
FetchLater#58726annevk merged 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Mar 24, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
4 tasks
Per the spec discussion in [1] we should only check for a length of `null` and not zero. [1]: whatwg/fetch#1902 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync
force-pushed
the
servo_export_43627
branch
from
fb2da23 to
e7fe72b
Compare
noamr
approved these changes
Apr 11, 2026
Contributor
|
@mingyc heads up that this will create a failed test in chromium. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the spec discussion in 1 we should only check for a length of
nulland not zero.Testing: Updates WPT test according to spec
Reviewed in servo/servo#43627