Test order of toggle events in addition to order of DOMSubtreeModified events.#40429
Merged
Merged
Conversation
wpt-pr-bot
approved these changes
Jun 7, 2023
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4599204
branch
from
0fc793e to
6c0cf92
Compare
…d events. I realized while writing whatwg/html#9400 (comment) that the ordering of the `open` attribute manipulation is also exposed through `toggle` events, so this tests those events in addition to `DOMSubtreeModified` events. Bug: 1444057 Change-Id: I6d3c65f5402053d77e4f6c488aa07209181a8cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599204 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1154716}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4599204
branch
from
6c0cf92 to
33b1fa9
Compare
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized while writing
whatwg/html#9400 (comment) that the
ordering of the
openattribute manipulation is also exposed throughtoggleevents, so this tests those events in addition toDOMSubtreeModifiedevents.Bug: 1444057
Change-Id: I6d3c65f5402053d77e4f6c488aa07209181a8cdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599204
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1154716}