Skip to content

Close popover stack when popovertarget attribute changes #39083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chromium-wpt-export-bot merged 1 commit into from
Mar 21, 2023
Merged

Close popover stack when popovertarget attribute changes #39083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions html/semantics/popovers/popover-target-element-disabled.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,3 +124,53 @@
'The outer popover be should be closed when the hierarchy is broken.');
}, 'Disconnecting popover*target buttons when popovers are open should close all popovers.');
</script>

<div id=outerpopover7 popover=auto>
<button id=togglebutton7 popovertarget=innerpopover7>toggle popover</button>
</div>
<div id=innerpopover7 popover=auto>popover</div>
<script>
test(() => {
outerpopover7.showPopover();
innerpopover7.showPopover();
assert_true(innerpopover7.matches(':open'),
'The inner popover should be able to open successfully.');
assert_true(outerpopover7.matches(':open'),
'The outer popover should stay open when opening the inner one.');

togglebutton7.setAttribute('popovertarget', 'otherpopover7');
assert_false(innerpopover7.matches(':open'),
'The inner popover be should be closed when the hierarchy is broken.');
assert_false(outerpopover7.matches(':open'),
'The outer popover be should be closed when the hierarchy is broken.');
}, 'Changing the popovertarget attribute to break the chain should close all popovers.');
</script>

<div id=outerpopover8 popover=auto>
<div id=middlepopover8 popover=auto>
<div id=innerpopover8 popover=auto>hello</div>
</div>
</div>
<div id=otherpopover8 popover=auto>other popover</div>
<button id=togglebutton8 popovertarget=middlepopover8>other button</div>
<script>
test(() => {
outerpopover8.showPopover();
middlepopover8.showPopover();
innerpopover8.showPopover();
assert_true(innerpopover8.matches(':open'),
'The inner popover should be able to open successfully.');
assert_true(middlepopover8.matches(':open'),
'The middle popover should stay open when opening the inner one.');
assert_true(outerpopover8.matches(':open'),
'The outer popover should stay open when opening the inner one.');

togglebutton8.setAttribute('popovertarget', 'otherpopover8');
assert_true(innerpopover8.matches(':open'),
'The inner popover should remain open.');
assert_true(middlepopover8.matches(':open'),
'The middle popover should remain open.');
assert_true(outerpopover8.matches(':open'),
'The outer popover should remain open.');
}, `Modifying popovertarget on a button which doesn't break the chain shouldn't close any popovers.`);
</script>