Skip to content

fix(core): reject negative DeepSeek coordinates #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linhongyu510 wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −3
Open

fix(core): reject negative DeepSeek coordinates #3067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/core/src/ai-model/models/deepseek/adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,18 @@ function parseDeepSeekCoordinateValues(
expectedLength: number,
label: string,
): number[] {
const coordinateTexts = String(input).match(/\d+/g);
if (coordinateTexts?.length !== expectedLength) {
const coordinateTexts = String(input).match(/[+-]?\d+/g);
const coordinates = coordinateTexts?.map(Number);
if (
coordinates?.length !== expectedLength ||
!coordinates.every((coordinate) => coordinate >= 0)
) {
throw new Error(
`DeepSeek ${label} locate result must contain exactly ${expectedLength} positive integers, got ${coordinateTexts?.length ?? 0}`,
);
}

return coordinateTexts.map(Number);
return coordinates;
}

function parseDeepSeekPointLocateValue(input: unknown): LocateResultValue {
Expand Down
24 changes: 24 additions & 0 deletions packages/core/tests/unit-test/model-adapter/deepseek.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ describe('deepseek model adapter', () => {
it.each([
'<｜｜point｜｜>[[928.5,780]]<｜｜/point｜｜>',
'<｜｜point｜｜>no coordinates<｜｜/point｜｜>',
'<｜｜point｜｜>[-10,500]<｜｜/point｜｜>',
'<｜｜point｜｜>[500,-10]<｜｜/point｜｜>',
])('rejects output without exactly two integers: %s', (content) => {
const locateAdapter = getStandardLocateAdapter().element;
const rawResult = locateAdapter.protocol.parseRawResponse(
Expand All @@ -226,6 +228,28 @@ describe('deepseek model adapter', () => {
).toThrow('must contain exactly 2 positive integers');
});

it.each([
'<｜｜ref｜｜>target<｜｜/ref｜｜><｜｜box｜｜>[[-1,100,200,300]]<｜｜/box｜｜>',
'<｜｜ref｜｜>target<｜｜/ref｜｜><｜｜box｜｜>[[100,-1,200,300]]<｜｜/box｜｜>',
'<｜｜ref｜｜>target<｜｜/ref｜｜><｜｜box｜｜>[[100,200,-1,300]]<｜｜/box｜｜>',
'<｜｜ref｜｜>target<｜｜/ref｜｜><｜｜box｜｜>[[100,200,300,-1]]<｜｜/box｜｜>',
])('rejects negative bbox coordinates: %s', (content) => {
const locateAdapter = getStandardLocateAdapter().searchArea!;
const rawResult = locateAdapter.protocol.parseRawResponse(
content,
locateAdapter.resultCodec.promptSpec,
);
if (rawResult.kind !== 'located') {
throw new Error('DeepSeek response should contain a raw location');
}

expect(() =>
locateAdapter.resultCodec.toPixelBbox(rawResult.target, {
preparedSize: { width: 1000, height: 1000 },
}),
).toThrow('must contain exactly 4 positive integers');
});

it.each([
'<｜｜point｜｜>[928,780]<｜｜/point｜｜>',
'<｜｜point｜｜>[[928 780]]<｜｜/point｜｜>',
Expand Down
Loading