Skip to content

Update retrieval configs to use separate models#17

Merged
danmichaeljones merged 5 commits into
mainfrom
update_retrieval_configs
May 29, 2026
Merged

Update retrieval configs to use separate models#17
danmichaeljones merged 5 commits into
mainfrom
update_retrieval_configs

Conversation

@danmichaeljones
Copy link
Copy Markdown
Contributor

  • Splits the RetrievalConfig model into separate models for each retrieval type, to make adding it easier to add extra parameters for one type only in future
  • Adds the option to use a string for retrieval_config to simplify changing the retrieval type while keeping default parameters, e.g.,
results = client.memories.search(
    query="Tell me about the user",
    user_id=USER_ID,
    retrieval_config="hyrbid",
)

Copy link
Copy Markdown

@orca-security-eu orca-security-eu Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@danmichaeljones danmichaeljones requested a review from a team May 29, 2026 12:21
Copy link
Copy Markdown
Member

@CShorten CShorten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks great -- curious about the slots parameter on dataclass, is this a memory allocation thing?

@danmichaeljones danmichaeljones merged commit bfc4475 into main May 29, 2026
14 checks passed
@danmichaeljones danmichaeljones deleted the update_retrieval_configs branch May 29, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants