Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
Contributor
There was a problem hiding this comment.
Pull request overview
Documents two MCP-related v1.38 server changes: runtime-configurability of the MCP enable/write flags via the runtime overrides YAML, and six new Prometheus weaviate_mcp_* metrics. Also bumps the local weaviate_version to 1.38.0.
Changes:
- Adds a "Runtime-configurable" column to the MCP env-var table and a new
## Monitoringsummary onmcp-server.mdx, plus runtime-configurable cross-links fromenv-vars/index.md. - Adds a new
### MCPoverrides subsection onruntime-config.md(with a note thatMCP_SERVER_CONFIG_PATHstays startup-only). - Adds a new
### MCP servermetrics section onmonitoring.mdenumerating the six metrics, labels, and label values; bumpsweaviate_versionto1.38.0.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| versions-config.json | Bumps local-build weaviate_version from 1.37.2 to 1.38.0. |
| docs/weaviate/configuration/mcp-server.mdx | Adds "Runtime-configurable" column to the env-var table and a new ## Monitoring section linking to monitoring.md; expected ### Toggle without restart subsection is missing. |
| docs/deploy/configuration/monitoring.md | New ### MCP server section listing six weaviate_mcp_* metrics with labels and value enumerations; minor table/whitespace cleanups in adjacent sections. |
| docs/deploy/configuration/env-vars/runtime-config.md | New ### MCP overrides subsection with mcp_server_enabled / mcp_server_write_access_enabled and a note that MCP_SERVER_CONFIG_PATH is intentionally not runtime-configurable; links to a not-yet-existing anchor on the MCP page. |
| docs/deploy/configuration/env-vars/index.md | Appends [Runtime-configurable](./runtime-config.md#mcp) from v1.38. to the two MCP env-var rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | --------------------------------------------------------------------------------------------------- | ------- | -------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | [`MCP_SERVER_ENABLED`](/deploy/configuration/env-vars#MCP_SERVER_ENABLED) | `false` | from `v1.38` | **Required.** Set to `true` to start the MCP server. | | ||
| | [`MCP_SERVER_WRITE_ACCESS_ENABLED`](/deploy/configuration/env-vars#MCP_SERVER_WRITE_ACCESS_ENABLED) | `false` | from `v1.38` | When `true`, enables write tools (`weaviate-objects-upsert`). Default is read-only. | | ||
| | [`MCP_SERVER_CONFIG_PATH`](/deploy/configuration/env-vars#MCP_SERVER_CONFIG_PATH) | `""` | No | Path to a YAML file for customizing tool descriptions (useful for prompt engineering the LLM's understanding of your specific data). If not provided or file malformed, the default descriptions from the [source code](https://github.com/weaviate/weaviate/tree/main/adapters/handlers/mcp) will be used. Tool descriptions are baked into the tool schemas at registration, so this flag remains startup-only. | |
|
|
||
| ### MCP | ||
|
|
||
| Added in `v1.38`. Toggling these at runtime does not require a cluster restart — the HTTP handlers stay registered and per-request checks pick up the new value. See [MCP server — Toggle without restart](/weaviate/configuration/mcp-server.mdx#toggle-without-restart) for behavior details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents two MCP-related server changes landing in v1.38:
MCP_SERVER_ENABLEDandMCP_SERVER_WRITE_ACCESS_ENABLEDare now runtime-configurable through the runtime overrides YAML. No cluster restart required to toggle MCP on/off or flip write access.MCP_SERVER_CONFIG_PATHstays startup-only by design (tool descriptions are baked into the tool schemas at registration). Disabled MCP now returns503 Service Unavailableinstead of501 Not Implemented.weaviate_mcp_*covering tool traffic, latency, in-flight concurrency, auth failures,tools/listtraffic, and the live state of the write-access flag.Files
docs/weaviate/configuration/mcp-server.mdx✓ (from v1.38);MCP_SERVER_CONFIG_PATHmarkedStartup-onlywith the reason inline.### Toggle without restartsubsection: YAML keys, 2-minute pickup window, the exact503response body verbatim, the disappearing-write-tool-from-tools/listbehavior, and a callout that v1.37.x clusters returned501so anyone monitoring/v1/mcphealth knows the status code shifts on upgrade.## Monitoringsection after Tools — six-row metrics summary table + link to the full catalogue.docs/deploy/configuration/env-vars/runtime-config.md### MCPsubsection under "Available overrides" (sibling to Raft / Usage tracking / Authentication) withmcp_server_enabledandmcp_server_write_access_enabled. Notes thatMCP_SERVER_CONFIG_PATHis intentionally not runtime-configurable, in the same place so anyone searching for it finds the explanation.docs/deploy/configuration/env-vars/index.md[Runtime-configurable](./runtime-config.md#mcp) from v1.38.to their descriptions — preserves the v1.37.1 "Added in" provenance.docs/deploy/configuration/monitoring.md### MCP serversection at the end of "Obtainable Metrics" (sibling of Replication). Full six-metric table with descriptions, labels, and types, plus an explicit enumeration of every label-value: fourstatusvalues, fourreasonvalues, twowrite_accessvalues. Thetoollabel is described inline (MCP tool name).Decisions called out
:::note. Status code change is incidental to the runtime-config feature; readers monitoring/v1/mcphealth will see it in context.Test plan
yarn buildclean (only the pre-existing unrelatedhnsw_startup_wait_for_vector_cacheanchor warning).mcp-server#toggle-without-restart,mcp-server#monitoring,monitoring#mcp-server,runtime-config#mcp).MCP_SERVER_ENABLED=true,RUNTIME_OVERRIDES_ENABLED=true,RUNTIME_OVERRIDES_PATH=/tmp/overrides.yaml,RUNTIME_OVERRIDES_LOAD_INTERVAL=1s. Flipmcp_server_enabled: falsein the YAML, wait, confirm/v1/mcpreturns503with the documented body. Re-enable, confirm 200. Same flow formcp_server_write_access_enabled— confirm the write tool disappears fromtools/list. Hit the Prometheus endpoint and confirm all sixweaviate_mcp_*metrics are scraped. The server-side testTestMCPRuntimeConfigTogglein PR #11176 already exercises this contract, so the docs match a tested behavior.Not in this PR
monitoring.mddoesn't currently cover MCP either — could land as a follow-up once a reference Grafana dashboard exists for the new metrics.