Repository navigation
Conversation
Deploying wasp-docs-on-main with
|
| Latest commit: |
7e145c1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd2891db.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://bot-5383-static-walkthrough.wasp-docs-on-main.pages.dev |
Contributor
There was a problem hiding this comment.
ℹ️ No blocking issues — one suggestion for the responsive regression test.
Approach: Sound — rendering the steps and examples as a static list removes the expand-and-collapse behavior that caused the page to jump.
Reviewed changes across the basic starter, its Playwright suite, and the docs:
- Walkthrough: All five numbered steps stay visible, with examples stacked below the instructions on mobile and beside them on desktop. Auth and routes are unchanged.
- Regression coverage: The Chromium cases check step and example visibility and page overflow at 375px and 1280px. Playwright discovery and Prettier passed; I did not rerun the browser tests.
- Docs: The welcome screenshot, generated snapshot reference, and changelog reflect the new layout.
gpt-6.2-sol | 𝕏
| has: page.getByRole("heading", { level: 3, name: title }), | ||
| }); | ||
| await expect(step.getByRole("heading", { level: 3 })).toBeVisible(); | ||
| await expect(step.getByRole("figure")).toBeVisible(); |
Contributor
There was a problem hiding this comment.
Both viewport tests would still pass if lg:grid-cols-2 were removed and desktop users got the stacked layout. Consider checking the relative position of the figure and instructions for one representative step: below the instructions at 375px and to their right at 1280px.
@wasp/spec
@wasp/cli
@wasp/cli-darwin-arm64-unknown
@wasp/cli-linux-arm64-glibc
@wasp/cli-linux-x64-glibc
@wasp/cli-linux-x64-musl
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes #5441. First slice of #5383; the broader design and dark mode stay open.
The basic starter's welcome page now keeps all five steps and their examples in place. On desktop the examples sit next to the instructions; on mobile they stack underneath. Same walkthrough, less jumping. No changes to Auth UI or routing.
Verified against a freshly generated basic starter in Chromium at 375px and 1280px. Both walkthrough regression tests passed, including the check that long code doesn't overflow the page.
mise run buildand the starter test suite's TypeScript build passed. Rebuilt the docs for the updated screenshot; all eight Markdown snapshots match.Agreement
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.