Skip to content

Keep the basic starter walkthrough from jumping - #5442

Open
wasp-bot wants to merge 2 commits into
mainfrom
bot/5383-static-walkthrough
Open

wasp-bot wants to merge 2 commits into
mainfrom
bot/5383-static-walkthrough

Conversation

@wasp-bot

@wasp-bot wasp-bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Fixes #5441. First slice of #5383; the broader design and dark mode stay open.

The basic starter's welcome page now keeps all five steps and their examples in place. On desktop the examples sit next to the instructions; on mobile they stack underneath. Same walkthrough, less jumping. No changes to Auth UI or routing.

Updated welcome page

Verified against a freshly generated basic starter in Chromium at 375px and 1280px. Both walkthrough regression tests passed, including the check that long code doesn't overflow the page. mise run build and the starter test suite's TypeScript build passed. Rebuilt the docs for the updated screenshot; all eight Markdown snapshots match.

Agreement

Type of change

  • 🔧 Just code/docs improvement
  • 🐞 Bug fix
  • 🚀 New/improved feature
  • 💥 Breaking change

Checklist

  • I tested my change in a Wasp app to verify that it works as intended.

  • 🧪 Tests and apps:

    • I added unit tests for my change.
    • (if you fixed a bug) I added a regression test for the bug I fixed.
    • (if you added/updated a feature) I added/updated e2e tests in examples/kitchen-sink/e2e-tests.
    • (if you added/updated a feature) I updated the starter templates in waspc/data/Cli/templates, as needed.
    • (if you added/updated a feature) I updated the example apps in examples/, as needed.
      • (if you updated examples/tutorials) I updated the tutorial in the docs (and vice versa).
  • 📜 Documentation:

    • (if you added/updated a feature) I added/updated the documentation in web/docs/.
  • 🆕 Changelog: (if change is more than just code/docs improvement)

    • I updated waspc/ChangeLog.md with a user-friendly description of the change.
    • (if you did a breaking change) I added a step to the current migration guide in web/docs/migration-guides/.
    • I bumped the version in waspc/waspc.cabal to reflect the changes I introduced.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Deploying wasp-docs-on-main with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e145c1
Status: ✅  Deploy successful!
Preview URL: https://dd2891db.wasp-docs-on-main.pages.dev
Branch Preview URL: https://bot-5383-static-walkthrough.wasp-docs-on-main.pages.dev

View logs

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No blocking issues — one suggestion for the responsive regression test.

Approach: Sound — rendering the steps and examples as a static list removes the expand-and-collapse behavior that caused the page to jump.

Reviewed changes across the basic starter, its Playwright suite, and the docs:

  • Walkthrough: All five numbered steps stay visible, with examples stacked below the instructions on mobile and beside them on desktop. Auth and routes are unchanged.
  • Regression coverage: The Chromium cases check step and example visibility and page overflow at 375px and 1280px. Playwright discovery and Prettier passed; I did not rerun the browser tests.
  • Docs: The welcome screenshot, generated snapshot reference, and changelog reflect the new layout.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using gpt-6.2-sol | 𝕏

has: page.getByRole("heading", { level: 3, name: title }),
});
await expect(step.getByRole("heading", { level: 3 })).toBeVisible();
await expect(step.getByRole("figure")).toBeVisible();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both viewport tests would still pass if lg:grid-cols-2 were removed and desktop users got the stacked layout. Consider checking the relative position of the figure and instructions for one representative step: below the instructions at 375px and to their right at 1280px.

@wasp-bot
wasp-bot deployed to railway-deploy-test November 20, 2026 23:35 — with GitHub Actions Active
@wasp-bot
wasp-bot deployed to fly-deploy-test November 20, 2026 23:35 — with GitHub Actions Active
@pkg-pr-new

pkg-pr-new Bot commented Nov 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

@wasp/spec

npx https://pkg.pr.new/@wasp/spec@5442

@wasp/cli

npx https://pkg.pr.new/@wasp/cli@5442

@wasp/cli-darwin-arm64-unknown

npx https://pkg.pr.new/@wasp/cli-darwin-arm64-unknown@5442

@wasp/cli-linux-arm64-glibc

npx https://pkg.pr.new/@wasp/cli-linux-arm64-glibc@5442

@wasp/cli-linux-x64-glibc

npx https://pkg.pr.new/@wasp/cli-linux-x64-glibc@5442

@wasp/cli-linux-x64-musl

npx https://pkg.pr.new/@wasp/cli-linux-x64-musl@5442

commit: 7e145c1

This branch was successfully deployed

2 active deployments
railway-deploy-test — 7e145c12 Deployed Nov 20, 2026 by wasp-bot via deploy-test / Test Railway deployment #15786
fly-deploy-test — 7e145c12 Deployed Nov 20, 2026 by wasp-bot via deploy-test / Test Fly deployment #15786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop the basic starter welcome walkthrough from jumping

1 participant